Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/chain #172

Merged
merged 22 commits into from
Jan 10, 2025
Merged

Refactor/chain #172

merged 22 commits into from
Jan 10, 2025

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Jan 4, 2025 •
edited
Loading

Reference Issues/PRs

This PR applies first step refactoring toward chain folder in order to decrease coupling and tiny may similar code repeat.
#44 #45

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added enhancement New feature or request refactoring labels Jan 4, 2025
@AHReccese AHReccese added this to the pymilo v1.2 milestone Jan 4, 2025
@AHReccese AHReccese self-assigned this Jan 4, 2025
@AHReccese AHReccese requested a review from sadrasabouri January 4, 2025 20:05
@AHReccese
Copy link
Member Author

@sadrasabouri
Hey Sadra, please do not merge after your review.

@AHReccese AHReccese marked this pull request as ready for review January 4, 2025 20:06
sadrasabouri
sadrasabouri requested changes Jan 5, 2025
View reviewed changes
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amirhossein. That was a great job. I left minor comments regarding the documentation. Hope they help.

pymilo/chains/chain.py Outdated Show resolved Hide resolved
pymilo/chains/chain.py Outdated Show resolved Hide resolved
pymilo/chains/chain.py Outdated Show resolved Hide resolved
pymilo/chains/chain.py Outdated Show resolved Hide resolved
pymilo/chains/chain.py Outdated Show resolved Hide resolved
pymilo/chains/chain.py Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sadrasabouri January 6, 2025 07:43
sadrasabouri
sadrasabouri approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

sepandhaghighi
sepandhaghighi approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi
Copy link
Member

@AHReccese Feel free to Squash/Merge this PR 🔥

@AHReccese AHReccese merged commit d3b9857 into dev Jan 10, 2025
25 checks passed
@AHReccese AHReccese deleted the refactor/chain branch January 10, 2025 01:04
This was linked to issues Jan 14, 2025
Refactoring1 (Code Style) #44
Closed
Refactoring2 (Performance) #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
pymilo v1.2
Development

Successfully merging this pull request may close these issues.

Refactoring2 (Performance) Refactoring1 (Code Style)
3 participants
@AHReccese @sepandhaghighi @sadrasabouri