Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/feature extraction #193

Open
wants to merge 51 commits into
base: dev
Choose a base branch
from
Open

Add/feature extraction #193

wants to merge 51 commits into from

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Feb 12, 2025

Reference Issues/PRs

#190
#191
#192

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added this to the pymilo v1.3 milestone Feb 12, 2025
@AHReccese AHReccese self-assigned this Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 67.94872% with 25 lines in your changes missing coverage. Please review.

Project coverage is 80.00%. Comparing base (51f9d84) to head (b92cf2c).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...ilo/transporters/feature_extraction_transporter.py 75.00% 8 Missing and 4 partials ⚠️
...transporters/general_data_structure_transporter.py 38.47% 4 Missing and 4 partials ⚠️
pymilo/chains/ensemble_chain.py 69.24% 2 Missing and 2 partials ⚠️
pymilo/streaming/communicator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #193      +/-   ##
==========================================
- Coverage   80.49%   80.00%   -0.49%     
==========================================
  Files          48       49       +1     
  Lines        2034     2104      +70     
  Branches      355      376      +21     
==========================================
+ Hits         1637     1683      +46     
- Misses        307      321      +14     
- Partials       90      100      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your effort 🥇
Please update SUPPORTED_MODELS.md file

@AHReccese AHReccese added enhancement New feature or request major major changes, to be reviewed in 10 days labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major major changes, to be reviewed in 10 days new feature
Projects
None yet
2 participants