Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clustering/kmeans #35

Merged
merged 22 commits into from
Oct 21, 2023
Merged

Clustering/kmeans #35

merged 22 commits into from
Oct 21, 2023

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

#17

What does this implement/fix? Explain your changes.

Add Clustering Chain
Add Kmeans(+test) support
Add Clustering purposed dataset and test
Add Clustering model's tests runner
Update test_pymilo.py and decouple the prediction from the pymiloing process(enhance the cohesiveness of pymiloing)

Any other comments?

@AHReccese AHReccese self-assigned this Sep 27, 2023
@AHReccese AHReccese added enhancement New feature or request new feature major major changes, to be reviewed in 10 days labels Sep 27, 2023
@AHReccese AHReccese added this to the pymilo v0.4 milestone Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pymilo/pymilo_param.py 90.66% <100.00%> (+0.25%) ⬆️
pymilo/utils/data_exporter.py 100.00% <100.00%> (ø)
pymilo/pymilo_func.py 79.48% <60.00%> (+3.01%) ⬆️
pymilo/utils/test_pymilo.py 87.50% <64.70%> (-8.66%) ⬇️
pymilo/chains/clustering_chain.py 77.77% <77.77%> (ø)

📢 Thoughts on this report? Let us know!.

@AHReccese
Copy link
Member Author

AHReccese commented Oct 1, 2023 •
edited
Loading

@sepandhaghighi
Hi, dear Sepand, I hope you're doing well, I suggest you review this major PR til 10/05/2023.
Although it is a major PR, it isn't complex that much.
I can explain the details whenever you want in our morning available for meeting times.

sepandhaghighi
sepandhaghighi requested changes Oct 7, 2023
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your efforts 🔥

  1. Take a look at my comments
  2. Please update CHANGELOG.md

@AHReccese
Copy link
Member Author

@sepandhaghighi
a kind reminder(since it is 4 days overdue(10 + 4 days), I know we're busy focusing on the proposal, but consider this reminder just as a commitment to the OSL guidelines.

sepandhaghighi
sepandhaghighi requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Sorry for my late response 🔥
Please take a look at my comments. Additionally, kindly update the CHANGELOG.md file. Thank you.

sepandhaghighi
sepandhaghighi approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit abca5ad into dev Oct 21, 2023
@sepandhaghighi sepandhaghighi deleted the clustering/kmeans branch October 21, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

Labels
enhancement New feature or request major major changes, to be reviewed in 10 days new feature
Projects
None yet
Milestone
pymilo v0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AHReccese @sepandhaghighi