Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clustering/regular models #49

Merged
merged 24 commits into from
Nov 7, 2023
Merged

Clustering/regular models #49

merged 24 commits into from
Nov 7, 2023

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

#17

What does this implement/fix? Explain your changes.

add support for these clustering models:

  • AffinityPropagation
  • MeanShift
  • SpectralClustering
  • AgglomerativeClustering
  • DBSCAN
  • OPTICS
  • GaussianMixture

Any other comments?

@AHReccese
add AffinityPropagation model test
e0f89b5
@AHReccese
add AffinityPropagation model to pymilo_param.py
f68473d
@AHReccese
add affinity_propagation test to clustering test runner
0b72f62
@AHReccese
add MeanShift model test
f82d1ea
@AHReccese
add MeanShift model to pymilo_param.py
7c7b882
@AHReccese
add MeanShift test to clustering test runner
f00eb35
@AHReccese
add DBSCAN model test
122f327
@AHReccese
add DBSCAN model to pymilo_param.py
5d395c3
@AHReccese
add DBSCAN test to clustering test runner
f78d7d8
@AHReccese
add optics test to clustering test runner
8ced798
@AHReccese
add OPTICS model test
6ad291c
@AHReccese
add OPTICS model to pymilo_param.py
f6ad064
@AHReccese
add SpectralClustering test to clustering test runner
47148ef
@AHReccese
add SpectralClustering model test
72d9a0b
@AHReccese
add SpectralClustering model to pymilo_param.py
1336b99
@AHReccese
add GaussianMixture test to clustering test runner
245f907
@AHReccese
add GaussianMixture model test
ea0a3e4
@AHReccese
add GaussianMixture model to pymilo_param.py
c07696f
@AHReccese
add AgglomerativeClustering test to clustering test runner
f7f9bfd
@AHReccese
add AgglomerativeClustering model test
3213c01
@AHReccese
add AgglomerativeClustering model to pymilo_param.py
9464fb2
@AHReccese AHReccese self-assigned this Oct 30, 2023
@AHReccese AHReccese added new feature minor minor changes, to be reviewed in max 5 days labels Oct 30, 2023
@AHReccese AHReccese added this to the pymilo v0.4 milestone Oct 30, 2023
@AHReccese AHReccese marked this pull request as ready for review October 31, 2023 05:40
@AHReccese
Copy link
Member Author

AHReccese commented Oct 31, 2023 •
edited
Loading

Hi, dear Sadra & Sepand, I hope you're doing well, since it is a minor PR, you can review it till 11/04/2023.
@sadrasabouri
@sepandhaghighi

@AHReccese AHReccese requested review from sadrasabouri and removed request for sepandhaghighi October 31, 2023 05:56
sadrasabouri
sadrasabouri approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pymilo/pymilo_param.py 91.46% <100.00%> (+0.79%) ⬆️

📢 Thoughts on this report? Let us know!

@AHReccese
Copy link
Member Author

@sepandhaghighi
considered time for minor PR review has been finished.
please review this PR ASAP.

@sepandhaghighi
Copy link
Member

@sepandhaghighi considered time for minor PR review has been finished. please review this PR ASAP.

Thanks for your reminder 🔥

sepandhaghighi
sepandhaghighi requested changes Nov 5, 2023
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese If required, could you kindly update the CHANGELOG.md?

@AHReccese
Copy link
Member Author

@sepandhaghighi I think I've done it.
What do you mean exactly?

@sepandhaghighi
Copy link
Member

@sepandhaghighi I think I've done it. What do you mean exactly?

I'm not sure if this list needs to be added to CHANGELOG.md, could you clarify?

AffinityPropagation
MeanShift
SpectralClustering
AgglomerativeClustering
DBSCAN
OPTICS
GaussianMixture

@AHReccese
Copy link
Member Author

@sepandhaghighi
you are right, unfortunately, I forgot to push the last commit :)).
done.

sepandhaghighi
sepandhaghighi approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit 844a6a2 into dev Nov 7, 2023
@sepandhaghighi sepandhaghighi deleted the clustering/regular_models branch November 7, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees

@AHReccese AHReccese

Labels
minor minor changes, to be reviewed in max 5 days new feature
Projects
None yet
Milestone
pymilo v0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@AHReccese @sepandhaghighi @sadrasabouri