Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Feat (Discover): Update styles to be compatible with next theme #4647

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a52e95c from #4644.

* Feat (Discover): Update styles to be compatible with next theme

1. Change doc table source highlight to use standard color functions instead of transparency
2. Build KUI CSS for next themes in OUI, and conditionally load to ensure surrounding doc view styled correctly
3. Update histogram styles to follow design guidance and avoid theme-specific imports

Signed-off-by: Josh Romero <[email protected]>

* add changelog

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit a52e95c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #4647 (09a4806) into 2.x (e8949b7) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              2.x    #4647      +/-   ##
==========================================
+ Coverage   66.06%   66.10%   +0.03%     
==========================================
  Files        3315     3315              
  Lines       63896    63895       -1     
  Branches    10122    10121       -1     
==========================================
+ Hits        42214    42238      +24     
+ Misses      19273    19172     -101     
- Partials     2409     2485      +76     
Flag Coverage Δ
Linux_1 34.76% <ø> (ø)
Linux_2 55.07% <ø> (?)
Linux_3 43.08% <0.00%> (+<0.01%) ⬆️
Linux_4 35.09% <ø> (ø)
Windows_1 34.78% <ø> (ø)
Windows_2 55.03% <ø> (ø)
Windows_3 43.08% <0.00%> (+<0.01%) ⬆️
Windows_4 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/legacy/ui/ui_render/ui_render_mixin.js 0.00% <ø> (ø)
...ublic/application/angular/directives/histogram.tsx 1.28% <0.00%> (+0.01%) ⬆️

... and 18 files with indirect coverage changes

@joshuarrrr joshuarrrr merged commit a9f0e53 into 2.x Aug 3, 2023
67 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-4644-to-2.x branch August 3, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants