[Data Explorer] Persisted state and syncing, shared context, linking state to component + smaller changes #4678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR might look big but its actually just 3 changes and a few cleanup tasks that simplify the app structure.
Changes:
_g
_a
_q
Other minor changes include:
docViewExpand
toexpandedHit
to make it clearer what it containssrc/plugins/discover/public/migrate_state.ts
and where ever its referenced.Note: The commit history has changes that have already been merged but the diff is accurate.
Issues Resolved
closes #4225
closes #4227
closes #4228
Screenshot
Ignore the layout issues, this will be fixed later
Screen.Recording.2023-08-01.at.4.15.59.AM.mov
Testing the changes
To test the state syncing:
To test the shared context, updating the columns should update the table and vice versa and only one network request should fire for an update in the netwprk tab to the
opensearch
routeCheck List
yarn test:jest
yarn test:jest_integration
yarn test:ftr