-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer][Discover 2.0] Enable sort and cell actions for table #4787
[Data Explorer][Discover 2.0] Enable sort and cell actions for table #4787
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4787 +/- ##
=========================================================
- Coverage 66.50% 66.35% -0.15%
=========================================================
Files 3289 3390 +101
Lines 62821 64729 +1908
Branches 9788 10306 +518
=========================================================
+ Hits 41782 42954 +1172
- Misses 18658 19231 +573
- Partials 2381 2544 +163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
392afb5
to
b2edd21
Compare
Signed-off-by: ananzh <[email protected]>
b2edd21
to
56f3330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like some snapshots are failing in ciGroup3 |
Signed-off-by: ananzh <[email protected]>
8766395
into
opensearch-project:feature/data-explorer
…pensearch-project#4787) * [Data Explorer][Discover 2.0] Enable sort and cell actions for table Signed-off-by: ananzh <[email protected]> * update test snapshot Signed-off-by: ananzh <[email protected]> --------- Signed-off-by: ananzh <[email protected]> (cherry picked from commit 8766395)
Description
This PR first enable sorting functionality
It also restores cell actions
Issue Resolve
#4775
#4776
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr