Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Explorer] Delete legacy discover selenium tests #5088

Merged
merged 2 commits into from
Sep 22, 2023
Merged

[Data Explorer] Delete legacy discover selenium tests #5088

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d51f81b
delete legacy discover functional tests
abbyhu2000 Sep 21, 2023
915ef19
remove discover folder in config file
abbyhu2000 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/plugins/discover/public/application/components/data_grid/data_grid_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ export const DataGridTable = ({
sorting={sorting}
toolbarVisibility={isToolbarVisible ? toolbarVisibility : false}
rowHeightsOptions={rowHeightsOptions}
data-description={'searchDescription'}
data-shared-item
data-title={'searchTitle'}
/>
),
[
Expand Down
1 change: 0 additions & 1 deletion test/functional/apps/context/_date_nanos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export default function ({ getService, getPageObjects }) {
await opensearchDashboardsServer.uiSettings.update({
'context:defaultSize': `${TEST_DEFAULT_CONTEXT_SIZE}`,
'context:step': `${TEST_STEP_SIZE}`,
'discover:v2': false,
});
});

Expand Down
1 change: 0 additions & 1 deletion test/functional/apps/context/_date_nanos_custom_timestamp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export default function ({ getService, getPageObjects }) {
await opensearchDashboardsServer.uiSettings.update({
'context:defaultSize': `${TEST_DEFAULT_CONTEXT_SIZE}`,
'context:step': `${TEST_STEP_SIZE}`,
'discover:v2': false,
});
});

Expand Down
4 changes: 0 additions & 4 deletions test/functional/apps/context/_filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,12 @@ export default function ({ getService, getPageObjects }) {
const docTable = getService('docTable');
const filterBar = getService('filterBar');
const retry = getService('retry');
const opensearchDashboardsServer = getService('opensearchDashboardsServer');
const browser = getService('browser');

const PageObjects = getPageObjects(['common', 'context']);

describe('context filters', function contextSize() {
beforeEach(async function () {
await opensearchDashboardsServer.uiSettings.replace({
'discover:v2': false,
});
await browser.refresh();
await PageObjects.context.navigateTo(TEST_INDEX_PATTERN, TEST_ANCHOR_ID, {
columns: TEST_COLUMN_NAMES,
Expand Down
1 change: 0 additions & 1 deletion test/functional/apps/context/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export default function ({ getService, getPageObjects, loadTestFile }) {
await opensearchArchiver.load('visualize');
await opensearchDashboardsServer.uiSettings.replace({
defaultIndex: 'logstash-*',
'discover:v2': false,
});
await PageObjects.common.navigateToApp('discover');
});
Expand Down
5 changes: 0 additions & 5 deletions test/functional/apps/dashboard/dashboard_state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,11 @@ export default function ({ getService, getPageObjects }) {
const retry = getService('retry');
const dashboardPanelActions = getService('dashboardPanelActions');
const dashboardAddPanel = getService('dashboardAddPanel');
const opensearchDashboardsServer = getService('opensearchDashboardsServer');

describe('dashboard state', function describeIndexTests() {
before(async function () {
await PageObjects.dashboard.initTests();
await PageObjects.dashboard.preserveCrossAppState();

await opensearchDashboardsServer.uiSettings.replace({
'discover:v2': false,
});
await browser.refresh();
});

Expand Down
4 changes: 0 additions & 4 deletions test/functional/apps/dashboard/panel_context_menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const dashboardPanelActions = getService('dashboardPanelActions');
const dashboardAddPanel = getService('dashboardAddPanel');
const dashboardVisualizations = getService('dashboardVisualizations');
const opensearchDashboardsServer = getService('opensearchDashboardsServer');
const listingTable = getService('listingTable');
const PageObjects = getPageObjects([
'dashboard',
Expand Down Expand Up @@ -126,9 +125,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const searchName = 'my search';

before(async () => {
await opensearchDashboardsServer.uiSettings.replace({
'discover:v2': false,
});
await browser.refresh();
await PageObjects.header.clickDiscover();
await PageObjects.discover.clickNewSearchButton();
Expand Down
69 changes: 0 additions & 69 deletions test/functional/apps/discover/_date_nanos.js
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions test/functional/apps/discover/_date_nanos_mixed.js
View file
Open in desktop

This file was deleted.

Loading
Loading