Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace]Add name and description characters limitation #7715

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7aef6e3 from #7656.

* Add name and description characters limitation

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #7656 created/updated

* Add workspace name and description limitation in server side

Signed-off-by: Lin Wang <[email protected]>

* Add unit tests for workspace name and description field

Signed-off-by: Lin Wang <[email protected]>

* Update test case name

Signed-off-by: Lin Wang <[email protected]>

* Allow input text when exceed max length

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7aef6e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (9320b9e) to head (e4b16f1).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...s/workspace_form/workspace_create_action_panel.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7715   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files        3637     3639    +2     
  Lines       80464    80480   +16     
  Branches    12777    12786    +9     
=======================================
+ Hits        51362    51377   +15     
  Misses      25974    25974           
- Partials     3128     3129    +1     
Flag Coverage Δ
Linux_1 29.89% <95.23%> (+0.01%) ⬆️
Linux_2 55.94% <ø> (ø)
Linux_3 40.44% <ø> (+<0.01%) ⬆️
Linux_4 31.46% <ø> (ø)
Windows_1 29.91% <95.23%> (+0.01%) ⬆️
Windows_2 55.89% <ø> (ø)
Windows_3 40.44% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit d3ee381 into 2.x Aug 15, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor v2.17.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants