-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Remove default appended features #7841
Merged
SuZhou-Joe
merged 2 commits into
opensearch-project:main
from
wanglam:feat-remove-workspace-detail-default-append
Aug 26, 2024
Merged
[Workspace]Remove default appended features #7841
SuZhou-Joe
merged 2 commits into
opensearch-project:main
from
wanglam:feat-remove-workspace-detail-default-append
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7841 +/- ##
==========================================
- Coverage 63.83% 63.83% -0.01%
==========================================
Files 3661 3661
Lines 81347 81343 -4
Branches 12978 12978
==========================================
- Hits 51926 51922 -4
Misses 26235 26235
Partials 3186 3186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
August 26, 2024 11:09
ruanyl
approved these changes
Aug 26, 2024
SuZhou-Joe
approved these changes
Aug 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Remove workspace_detail from default append features Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7841 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ca66127) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Remove workspace_detail from default append features * Changeset file for PR #7841 created/updated --------- (cherry picked from commit ca66127) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for removing default appended features logic for workspace create and update page. For now only
workspace_detail
will be appended to the features array in the workspace form. But theworkspace_detail
feature already been added to workspace's use case in this code. Which means theworkspace_detail
feature will always be able to access inside workspace, then we don't need to append by default.Issues Resolved
#7844
Screenshot
No UI changes
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
POST /api/workspaces
request in devtools, the features array should not includesworkspace_detail
like below imagePUT /api/workspaces/{:id}
, the features array should not includesworkspace_detail
like below imageChangelog
Check List
yarn test:jest
yarn test:jest_integration