[Workspace]Fix workspace description error when name invalid #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8079 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 3738 3738
Lines 88674 88674
Branches 13782 13782
=======================================
Hits 53727 53727
Misses 31662 31662
Partials 3285 3285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ruanyl
reviewed
Sep 9, 2024
| onChange={setDescription} | ||
| error={formErrors.name?.message} | ||
| /> | ||
| <WorkspaceDescriptionField value={formData.description} onChange={setDescription} /> |
There was a problem hiding this comment.
Does description field have validation?
There was a problem hiding this comment.
No validation for description field for now.
There was a problem hiding this comment.
Ok, I thought we have 200 size limit
There was a problem hiding this comment.
Yeah, the workspace description field will turn to red. And the create workspace button will be disabled when description text over 200 characters. But the "Saved changes" button won't be disabled in the edit mode in workspace detail page. Do we need to add this in current PR?
There was a problem hiding this comment.
I'm fine with having it in a separate PR
SuZhou-Joe
approved these changes
Sep 9, 2024
SuZhou-Joe
added
bug
ruanyl
approved these changes
Sep 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Fix workspace description error when name invalid Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8079 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ee5d482) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Fix workspace description error when name invalid Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8079 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ee5d482) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 10, 2024
…8083) * Fix workspace description error when name invalid * Changeset file for PR #8079 created/updated --------- (cherry picked from commit ee5d482) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 10, 2024
…8084) * Fix workspace description error when name invalid * Changeset file for PR #8079 created/updated --------- (cherry picked from commit ee5d482) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for fixing workspace description field error when name invalid in the workspace create and detail page.
Issues Resolved
#8081
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignoreconfig/opensearch_dashboards.ymlyarn start --no-base-pathChangelog
Check List
yarn test:jestyarn test:jest_integration