Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deprecated): removed deprecated yarn attributes #8479

Closed
wants to merge 1 commit into from

Conversation

rios0rios0
Copy link

@rios0rios0 rios0rios0 commented Oct 4, 2024

Description

Removed deprecated flags that avoid using newer yarn versions, like corepack and any yarn >= 1.xx.

Issues Resolved

Screenshot

Before

Before

After

After

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Oct 4, 2024

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8479.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@rios0rios0 rios0rios0 changed the title Main fix(deprecated): removed deprecated yarn attributes Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 8479.yml under folder changelogs/fragments to complete this PR. File still missing.

1 similar comment
Copy link
Contributor

github-actions bot commented Oct 4, 2024

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 8479.yml under folder changelogs/fragments to complete this PR. File still missing.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (4129d4d) to head (e3321ae).
Report is 146 commits behind head on main.

Files with missing lines Patch % Lines
packages/osd-pm/src/utils/scripts.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8479      +/-   ##
==========================================
- Coverage   60.94%   60.93%   -0.01%     
==========================================
  Files        3759     3759              
  Lines       89323    89323              
  Branches    13973    13973              
==========================================
- Hits        54434    54432       -2     
- Misses      31492    31493       +1     
- Partials     3397     3398       +1     
Flag Coverage Δ
Linux_1 28.92% <ø> (ø)
Linux_2 56.30% <0.00%> (ø)
Linux_3 37.77% <ø> (-0.01%) ⬇️
Linux_4 29.93% <ø> (ø)
Windows_1 28.93% <ø> (ø)
Windows_2 56.25% <0.00%> (ø)
Windows_3 37.77% <ø> (ø)
Windows_4 29.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh added the v2.19.0 label Oct 30, 2024
@rios0rios0
Copy link
Author

I did a workaround with search and replace since nobody answered my PR.

@rios0rios0 rios0rios0 closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants