Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation]feat: update border style when new left nav expanded #8489

Merged
merged 4 commits into from
Oct 7, 2024
Merged

[navigation]feat: update border style when new left nav expanded #8489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5db014a
feat: update border style
SuZhou-Joe Oct 4, 2024
9250269
Changeset file for PR #8489 created/updated
opensearch-changeset-bot[bot] Oct 4, 2024
876e167
feat: update
SuZhou-Joe Oct 4, 2024
6663fd4
feat: update border color
SuZhou-Joe Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8489.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
feat:
- Update border style when new left nav expanded ([#8489](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8489))
9 changes: 0 additions & 9 deletions src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_group_enabled.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@
}

&.bottom-container-expanded {
@include euiBottomShadowLarge($euiColorMediumShade, 0.1, true, true);

gap: 16px;
padding-top: $euiSizeM;
padding-bottom: $euiSizeM;
border-top: $euiBorderThin;
border-color: $euiColorMediumShade;
}
}

Expand Down
10 changes: 1 addition & 9 deletions src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,7 @@
*/

import './collapsible_nav_group_enabled.scss';
import {
EuiFlyout,
EuiPanel,
EuiHorizontalRule,
EuiHideFor,
EuiFlyoutProps,
EuiShowFor,
} from '@elastic/eui';
import { EuiFlyout, EuiPanel, EuiHideFor, EuiFlyoutProps, EuiShowFor } from '@elastic/eui';
import { i18n } from '@osd/i18n';
import React, { useMemo } from 'react';
import useObservable from 'react-use/lib/useObservable';
Expand Down Expand Up @@ -250,7 +243,6 @@ export function CollapsibleNavGroupEnabled({
// This element is used to push icons to the bottom of left navigation when collapsed
!isNavOpen ? <div className="flex-1-container" /> : null
}
<EuiHorizontalRule margin="none" />
<div
className={classNames({
'bottom-container': true,
Expand Down
Loading