Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Analytics use case overview and essential use case overview crashed #8524

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[Workspace]Analytics use case overview and essential use case overview crashed #8524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d05ee64
Remove collaboratorTypes in renderUseCaseOverviewApp
wanglam Oct 8, 2024
d3d74fe
Changeset file for PR #8524 created/updated
opensearch-changeset-bot[bot] Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8524.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- [Workspace]Analytics use case overview and essential use case overview crashed ([#8524](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8524))
2 changes: 1 addition & 1 deletion src/plugins/workspace/public/application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export const renderInitialApp = (

export const renderUseCaseOverviewApp = async (
{ element }: AppMountParameters,
services: Services,
services: Omit<Services, 'collaboratorTypes'>,
pageId: string
) => {
ReactDOM.render(
Expand Down
2 changes: 0 additions & 2 deletions src/plugins/workspace/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,6 @@ export class WorkspacePlugin
workspaceClient,
dataSourceManagement,
contentManagement: contentManagementStart,
collaboratorTypes: this.collaboratorTypes,
};

return renderUseCaseOverviewApp(params, services, ESSENTIAL_OVERVIEW_PAGE_ID);
Expand Down Expand Up @@ -502,7 +501,6 @@ export class WorkspacePlugin
workspaceClient,
dataSourceManagement,
contentManagement: contentManagementStart,
collaboratorTypes: this.collaboratorTypes,
};

return renderUseCaseOverviewApp(params, services, ANALYTICS_ALL_OVERVIEW_PAGE_ID);
Expand Down
Loading