Encode searchId as it tends to be decoded after adds into url #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Entry Too LongEntry is 114 characters long, which is 14 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 105 characters long, which is 5 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
mengweieric
as code owners
zhyuanqi
requested review from
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
zhyuanqi
added
backport 2.x
v2.18.0
visualizations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8530 +/- ##
=======================================
Coverage 60.93% 60.93%
=======================================
Files 3769 3769
Lines 89506 89507 +1
Branches 14012 14013 +1
=======================================
+ Hits 54539 54542 +3
+ Misses 31557 31556 -1
+ Partials 3410 3409 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Oct 9, 2024
zhongnansu
approved these changes
Oct 9, 2024
SuZhou-Joe
approved these changes
Oct 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Encode searchId as it tends to be decoded after adds into url Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Changeset file for PR #8530 created/updated * Changeset file for PR #8530 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9eae148) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
removed
visualizations
zhyuanqi
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Oct 10, 2024
7 tasks
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Oct 11, 2024
…arch-project#8530) * Encode searchId as it tends to be decoded after adds into url Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Changeset file for PR opensearch-project#8530 created/updated * Changeset file for PR opensearch-project#8530 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…arch-project#8530) * Encode searchId as it tends to be decoded after adds into url Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Changeset file for PR opensearch-project#8530 created/updated * Changeset file for PR opensearch-project#8530 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue that when adding a new visualization, the visualization id would be decoded and leads to not found.
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration