Fix Selecting Dataset with Default Configuration #8534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suchit Sahoo <[email protected]>
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
LDrago27
added
discover
github-actions
bot
added
the
Skip-Changelog
LDrago27
removed
the
Skip-Changelog
LDrago27
changed the title
github-actions
bot
added
the
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8534 +/- ##
==========================================
- Coverage 60.93% 60.93% -0.01%
==========================================
Files 3767 3769 +2
Lines 89387 89508 +121
Branches 13985 14013 +28
==========================================
+ Hits 54471 54543 +72
- Misses 31519 31556 +37
- Partials 3397 3409 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This should be fixed in #8166. |
|
Not required fixed by #8166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Selecting a dataset with default configuration resulted in a bad search. Refer the video below for details.
Meeting+Recording+-+Sahoo.+Suchit+Instant+Meeting.2.mp4
Issues Resolved
Screenshot
Testing the changes
Meeting+Recording+-+Sahoo.+Suchit+Instant+Meeting.3.mp4
Changelog
Check List
yarn test:jestyarn test:jest_integration