Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Add global search bar into left nav #8538
[Workspace] Add global search bar into left nav #8538
Changes from 9 commits
fbd86d5
37cd6f6
3a7a107
024f2fb
4a1c182
96b2e92
bb53a65
de606ad
c4c28ca
7f94dbc
fb673d1
ed21641
2d58cf0
ea06fd1
600b803
b5f66b0
2d13afa
b918836
47f45e8
e9fb891
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 90 in src/core/public/chrome/chrome_service.mock.ts
Codecov / codecov/patch
src/core/public/chrome/chrome_service.mock.ts#L90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use search strategy as the name? We already have a concept of search strategy in the application. This is used for the actual search queries. Lets call these commands. Here is a really good extensible model that VS code uses for their global search. https://code.visualstudio.com/api/references/contribution-points#contributes.commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename it to searchCommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
run
. This works well with the term command too. So it will becommand.run(props)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this method name to
run
as wellSome generated files are not rendered by default. Learn more about how customized files appear on GitHub.