Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Create Snapshot Add role_arn to s3 repository #8542

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

getsolaris
Copy link

@getsolaris getsolaris commented Oct 10, 2024

Description

Create Snapshot Add role_arn to s3 repository

Issues Resolved

Changelog

  • feat: [Console] Add role_arn to the snapshot create repository

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

1 similar comment
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Oct 10, 2024
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 10, 2024
@ananzh ananzh added the v2.19.0 label Oct 30, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (615d7d4) to head (8ec9417).
Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8542      +/-   ##
==========================================
- Coverage   60.95%   60.95%   -0.01%     
==========================================
  Files        3776     3776              
  Lines       89638    89638              
  Branches    14045    14045              
==========================================
- Hits        54639    54636       -3     
- Misses      31587    31588       +1     
- Partials     3412     3414       +2     
Flag Coverage Δ
Linux_1 29.08% <ø> (ø)
Linux_2 56.27% <ø> (ø)
Linux_3 37.75% <ø> (-0.01%) ⬇️
Linux_4 29.92% <ø> (-0.01%) ⬇️
Windows_1 29.09% <ø> (ø)
Windows_2 56.23% <ø> (ø)
Windows_3 37.75% <ø> (ø)
Windows_4 29.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants