-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Async search Discover] Poll for results when current request completes #8555
Merged
virajsanghvi
merged 4 commits into
opensearch-project:main
from
amsiglan:fix-polling-frequency
Oct 18, 2024
Merged
[Async search Discover] Poll for results when current request completes #8555
virajsanghvi
merged 4 commits into
opensearch-project:main
from
amsiglan:fix-polling-frequency
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 11, 2024 01:59
AMoo-Miki
reviewed
Oct 11, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8555 +/- ##
=======================================
Coverage 60.95% 60.96%
=======================================
Files 3776 3776
Lines 89638 89651 +13
Branches 14045 14045
=======================================
+ Hits 54639 54652 +13
Misses 31587 31587
Partials 3412 3412
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
ashwin-pc
approved these changes
Oct 18, 2024
virajsanghvi
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
…es (#8555) * poll for results when current request completes Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR #8555 created/updated * added localization to error string Signed-off-by: Amardeepsingh Siglani <[email protected]> * simplified error message for user Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6379548) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Oct 18, 2024
…es (#8555) (#8655) * poll for results when current request completes * Changeset file for PR #8555 created/updated * added localization to error string * simplified error message for user --------- (cherry picked from commit 6379548) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan
added a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2024
…es (opensearch-project#8555) * poll for results when current request completes Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR opensearch-project#8555 created/updated * added localization to error string Signed-off-by: Amardeepsingh Siglani <[email protected]> * simplified error message for user Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…es (opensearch-project#8555) * poll for results when current request completes Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR opensearch-project#8555 created/updated * added localization to error string Signed-off-by: Amardeepsingh Siglani <[email protected]> * simplified error message for user Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…es (opensearch-project#8555) * poll for results when current request completes Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR opensearch-project#8555 created/updated * added localization to error string Signed-off-by: Amardeepsingh Siglani <[email protected]> * simplified error message for user Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the polling logic for async search in Discover to poll for the query status once the current call resolves.
Currently we fire a polling request every 5 seconds irrespective of whether the previous status check call completed or not.
This will ensure we make fewer polling calls
Screenshot
N/A
Testing the changes
Tested using local setup
Changelog
Check List
yarn test:jest
yarn test:jest_integration