Handle Server Side Errors #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
all-star-contributor
Skip-Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8562 +/- ##
==========================================
+ Coverage 60.93% 60.96% +0.02%
==========================================
Files 3769 3776 +7
Lines 89508 89655 +147
Branches 14013 14048 +35
==========================================
+ Hits 54541 54654 +113
- Misses 31557 31590 +33
- Partials 3410 3411 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
force-pushed
the
secFix
branch
4 times, most recently
from
d1fceaa
to
4458935
Compare
Signed-off-by: Suchit Sahoo <[email protected]>
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
virajsanghvi
as code owners
Hailong-am
reviewed
Oct 12, 2024
| await internalRepository.incrementCounter('dql-telemetry', 'dql-telemetry', counterName); | ||
| } catch (error) { | ||
| logger.warn(`Unable to increment counter: ${error}`); | ||
| return response.customError({ | ||
| statusCode: error.status, | ||
| statusCode: error.status || 403, |
There was a problem hiding this comment.
why the default status code be 403?
There was a problem hiding this comment.
The additional error scenario that we are trying to capture are failures during the initialization of const internalRepository = savedObjects.createScopedRepository(request);. This failures occur if the users permissions are lacking. Hence added the default 403 since for other errors they already have an associated status code.
ananzh
approved these changes
Oct 14, 2024
sejli
approved these changes
Oct 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit 2be8d04) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Oct 15, 2024
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles internal Server Error that were being thrown.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration