-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix padding and responsive behavior of page header #8600
fix: Fix padding and responsive behavior of page header #8600
Conversation
Signed-off-by: Viraj Sanghvi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8600 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3790 3790
Lines 90296 90296
Branches 14151 14151
=======================================
Hits 55036 55036
Misses 31804 31804
Partials 3456 3456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Does this also fix the header for application pages like discover, visualize and dashboards? |
It does not address any issues on app headers - can you call out what the issue there is? |
* fix: Fix padding and responsive behavior of page header Signed-off-by: Viraj Sanghvi <[email protected]> * Changeset file for PR #8600 created/updated --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit db51ee1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: Fix padding and responsive behavior of page header * Changeset file for PR #8600 created/updated --------- (cherry picked from commit db51ee1) Signed-off-by: Viraj Sanghvi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…roject#8600) * fix: Fix padding and responsive behavior of page header Signed-off-by: Viraj Sanghvi <[email protected]> * Changeset file for PR opensearch-project#8600 created/updated --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…roject#8600) * fix: Fix padding and responsive behavior of page header Signed-off-by: Viraj Sanghvi <[email protected]> * Changeset file for PR opensearch-project#8600 created/updated --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…roject#8600) * fix: Fix padding and responsive behavior of page header Signed-off-by: Viraj Sanghvi <[email protected]> * Changeset file for PR opensearch-project#8600 created/updated --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Fixes padding and responsive behavior of page header on feature pages
Issues Resolved
Screenshot
Testing the changes
Tested locally + had UX validate
Changelog
Check List
yarn test:jest
yarn test:jest_integration