Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add SearchOnLoad Preference for dataset #8610

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[Backport 2.x] Add SearchOnLoad Preference for dataset #8610

merged 1 commit into from
Oct 17, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5c8b2e3 from #8513.

@github-actions
Add searchOnLoad property to datasets (#8513)
57f46c9 
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit 5c8b2e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry all-star-contributor discover-next v2.18.0 labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 16, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (14a4ba7) to head (57f46c9).
Report is 9 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ic/application/view_components/utils/use_search.ts 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8610      +/-   ##
==========================================
- Coverage   61.02%   61.01%   -0.01%     
==========================================
  Files        3784     3784              
  Lines       90225    90235      +10     
  Branches    14122    14125       +3     
==========================================
  Hits        55056    55056              
- Misses      31719    31729      +10     
  Partials     3450     3450
Flag Coverage Δ
Linux_1 29.23% <0.00%> (-0.01%) ⬇️
Linux_2 56.53% <ø> (ø)
Linux_3 37.75% <0.00%> (-0.01%) ⬇️
Linux_4 30.02% <ø> (ø)
Windows_1 29.24% <0.00%> (-0.01%) ⬇️
Windows_2 56.48% <ø> (ø)
Windows_3 37.75% <0.00%> (-0.01%) ⬇️
Windows_4 30.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 merged commit 1b983d1 into 2.x Oct 17, 2024
70 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-8513-to-2.x branch October 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LDrago27 @sejli