-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Workspace assets page crashed after library_write permission revoked #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 18, 2024 08:16
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8648 +/- ##
==========================================
+ Coverage 60.86% 60.88% +0.01%
==========================================
Files 3790 3790
Lines 90235 90253 +18
Branches 14144 14153 +9
==========================================
+ Hits 54924 54948 +24
+ Misses 31846 31834 -12
- Partials 3465 3471 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Oct 18, 2024
Hailong-am
previously approved these changes
Oct 18, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am
approved these changes
Oct 18, 2024
SuZhou-Joe
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
…ion revoked (#8648) * fix copy issue Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #8648 created/updated * fix: snapshot Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 0e00abf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Oct 18, 2024
…ion revoked (#8648) (#8654) * fix copy issue * Changeset file for PR #8648 created/updated * fix: snapshot --------- (cherry picked from commit 0e00abf) Signed-off-by: yubonluo <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2024
…ion revoked (opensearch-project#8648) * fix copy issue Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#8648 created/updated * fix: snapshot Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…ion revoked (opensearch-project#8648) * fix copy issue Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#8648 created/updated * fix: snapshot Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…ion revoked (opensearch-project#8648) * fix copy issue Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#8648 created/updated * fix: snapshot Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reproduce steps:
Error screenshot:
Issues Resolved
Screenshot
2024-10-18.16.14.46.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration