-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x-manual-backport][Discover] Add Footer Bar for Single Line Editor (#8565) #8691
Conversation
…opensearch-project#8565) Backport PR: opensearch-project#8565 From the original PR: * initial commit for single line editor footer Signed-off-by: Sean Li <[email protected]> * fixing styling and functionality Signed-off-by: Sean Li <[email protected]> * Changeset file for PR opensearch-project#8565 created/updated * fixing bug with error not showing up in footer Signed-off-by: Sean Li <[email protected]> * fixing loading state thanks ashwinpc Signed-off-by: Sean Li <[email protected]> * trying to surface errors Signed-off-by: Sean Li <[email protected]> * adding new error for error state Signed-off-by: Sean Li <[email protected]> * Revert "fixing loading state thanks ashwinpc" This reverts commit 64b5969. * correctly passing async search strat errors Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8691 +/- ##
==========================================
- Coverage 60.95% 60.93% -0.02%
==========================================
Files 3792 3792
Lines 90464 90488 +24
Branches 14197 14202 +5
==========================================
+ Hits 55140 55142 +2
- Misses 31838 31861 +23
+ Partials 3486 3485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There is a snapshot test failure... Is this expected, @sejli? |
Signed-off-by: Anan Zhuang <[email protected]>
Backport PR:
#8565
From the original PR:
initial commit for single line editor footer
fixing styling and functionality
Changeset file for PR [Discover] Add Footer Bar for Single Line Editor #8565 created/updated
fixing bug with error not showing up in footer
fixing loading state thanks ashwinpc
trying to surface errors
adding new error for error state
Revert "fixing loading state thanks ashwinpc"
This reverts commit 64b5969.
Changelog
Check List
yarn test:jest
yarn test:jest_integration