Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x] Add support for async ppl to discover (#8706) #8769

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[Manual backport 2.x] Add support for async ppl to discover (#8706) #8769

merged 1 commit into from
Oct 31, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 30, 2024

Description

Backport PR:
#8706

From original PR:

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ps48 @opensearch-changeset-bot @ananzh
[Manual backport 2.x] Add support for async ppl to discover (opensear…
5a12276 
…ch-project#8706)

Backport PR:
opensearch-project#8706

From original PR:
* add support for async ppl to discover

Signed-off-by: Shenoy Pratik <[email protected]>

* Changeset file for PR opensearch-project#8706 created/updated

* update s3_type test to add PPL as supported lang

Signed-off-by: Shenoy Pratik <[email protected]>

* fix lint error

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

joshuali925
joshuali925 reviewed Oct 30, 2024
View reviewed changes
src/plugins/query_enhancements/server/search/ppl_async_search_strategy.ts
} as IDataFrameResponse;
} else {
request.params = { queryId: inProgressQueryId };
const queryStatusResponse: any = await pplAsyncJobsFacet.describeQuery(context, request);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ps48 should this have

if (!queryStatusResponse.success) handleFacetError(queryStatusResponse);

otherwise if queryStatusResponse.success is false, then queryStatusResponse.data is the Error object, not actual data and can't be processed?
see https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8765/files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ps48 will do a separate follow up PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up PR is #8771

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.83%. Comparing base (25c3ac3) to head (5a12276).
Report is 7 commits behind head on 2.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8769      +/-   ##
==========================================
- Coverage   60.84%   60.83%   -0.01%     
==========================================
  Files        3797     3797              
  Lines       90706    90706              
  Branches    14269    14269              
==========================================
- Hits        55187    55185       -2     
- Misses      32025    32026       +1     
- Partials     3494     3495       +1
Flag Coverage Δ
Linux_1 29.06% <ø> (ø)
Linux_2 56.53% <ø> (ø)
Linux_3 37.63% <ø> (-0.01%) ⬇️
Linux_4 29.94% <100.00%> (ø)
Windows_1 29.08% <ø> (ø)
Windows_2 56.48% <ø> (ø)
Windows_3 37.63% <ø> (ø)
Windows_4 29.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh merged commit 1cc5c0f into opensearch-project:2.x Oct 31, 2024
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
failed changeset v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @joshuali925 @sejli @ps48