[Discover] Remove Default Cluster

[sejli]

Description

Removes default cluster from index and S3 dataset types cluster lists

Issues Resolved

Screenshot

Testing the changes

Changelog

• skip

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[kavilla]

will need to fast follow on checking if local cluster is available

[ashwin-pc]

Lets fast follow to allow local cluster to show up as well

[joshuali925]

approving but we should add some logic to check and add if local datasource exists, and it should say local cluster, not default cluster when we do

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.75%. Comparing base (3381dcd) to head (47ed6af).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ery/query_string/dataset_service/lib/index_type.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8778   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files        3798     3798           
  Lines       90690    90690           
  Branches    14277    14277           
=======================================
  Hits        55101    55101           
  Misses      32090    32090           
  Partials     3499     3499           

Flag	Coverage Δ
Linux_1	29.05% <0.00%> (ø)
Linux_2	56.39% <ø> (ø)
Linux_3	37.61% <0.00%> (ø)
Linux_4	29.82% <57.14%> (ø)
Windows_1	29.07% <0.00%> (ø)
Windows_2	56.34% <ø> (ø)
Windows_3	37.61% <0.00%> (ø)
Windows_4	29.82% <57.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kavilla]

LGTM. Could we verify the source of the error. Is from the API and we should have fixed the response, or is it because we always need to have a data source if now. I would be surprised we are the only ones that ran into this issue. I thought it was save to assume if no data source Id then the default data source Is used.