[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW #8788

AMoo-Miki · 2024-11-01T18:57:34Z

Description

[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, ja-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW

Changelog

feat: [i18n-dev] Allow updating existing localization files when importing with "i18n:integrate"
feat: [i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, pt-PT, and tr-TR
feat: [i18n] Add additional translations for ja-JP, ko-KR, zh-CN, and zh-TW

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-11-01T18:58:05Z

❌ Entry Too Long

Entry is 119 characters long, which is 19 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

github-actions · 2024-11-01T18:59:57Z

❌ Invalid Prefix

Invalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

codecov · 2024-11-01T19:18:26Z

Codecov Report

Attention: Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (affd265) to head (63140cb).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
src/dev/i18n/integrate_locale_files.ts	82.60%	4 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8788      +/-   ##
==========================================
+ Coverage   60.75%   60.80%   +0.04%     
==========================================
  Files        3798     3798              
  Lines       90690    90734      +44     
  Branches    14277    14290      +13     
==========================================
+ Hits        55101    55169      +68     
+ Misses      32090    32065      -25     
- Partials     3499     3500       +1

Flag	Coverage Δ
Linux_1	`29.05% <ø> (-0.01%)`	⬇️
Linux_2	`56.39% <ø> (ø)`
Linux_3	`37.65% <ø> (+0.04%)`	⬆️
Linux_4	`29.87% <82.60%> (+0.04%)`	⬆️
Windows_1	`29.06% <ø> (-0.01%)`	⬇️
Windows_2	`56.34% <ø> (ø)`
Windows_3	`37.65% <ø> (+0.04%)`	⬆️
Windows_4	`29.87% <82.60%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joshuali925 · 2024-11-01T21:27:18Z

src/dev/i18n/integrate_locale_files.ts

@@ -206,19 +215,94 @@ async function writeMessages(
  }
 }

+function isSpreadableObject(value: unknown) {
+  try {
+    return { ...value }, true;


i think [...null] results in error but {...null} works, should it consider null as non spreadable?

reading a bit more seems it's iterable vs enumerable, looking at usage i think it's fine since it's spreading into an object

null is an acceptable argument but thanks for thinking about it.

joshuali925 · 2024-11-01T21:28:19Z

src/dev/i18n/integrate_locale_files.ts

+      return false; // Found a key, so it is NOT empty
+    }
+  }
+  return true;


we don't have lodash for these?

We are actively trying to phase out lodash.

ashwin-pc · 2024-11-02T00:02:17Z

src/dev/i18n/integrate_locale_files.ts

Can we add some tests for these?

The existing tests for this functionality are pretty inadequate. I have created an issue for it:
#8791

Added some tests for the new functionality.

…with "i18n:integrate" Signed-off-by: Miki <[email protected]>

…-IT, ja-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW Signed-off-by: Miki <[email protected]>

kavilla

cool!

virajsanghvi

Thanks for meeting patch coverage!

A cypress test is failing, but looks like that's been happening elsewhere

AMoo-Miki · 2024-11-06T17:09:25Z

ciGroup10 is new group which currently has no tests. Hence merging this PR.

…-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW (#8788) * [i18n-dev] Allow updating existing localization files when importing with "i18n:integrate" Signed-off-by: Miki <[email protected]> * [i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, ja-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW Signed-off-by: Miki <[email protected]> * Changeset file for PR #8788 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 87832f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW (#8788) (#8821) * [i18n-dev] Allow updating existing localization files when importing with "i18n:integrate" * [i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, ja-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW * Changeset file for PR #8788 created/updated --------- (cherry picked from commit 87832f3) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the distinguished-contributor label Nov 1, 2024

github-actions bot added the failed changeset label Nov 1, 2024

github-actions bot removed the failed changeset label Nov 1, 2024

opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 1, 2024

Changeset file for PR opensearch-project#8788 created/updated

aacf405

AMoo-Miki force-pushed the new-translations branch from aacf405 to ae5a04f Compare November 1, 2024 19:00

opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 1, 2024

Changeset file for PR opensearch-project#8788 created/updated

dbe4c40

AMoo-Miki added i18n Internationalization related Issues and PRs backport 2.x labels Nov 1, 2024

joshuali925 previously approved these changes Nov 1, 2024

View reviewed changes

ashwin-pc reviewed Nov 2, 2024

View reviewed changes

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 4, 2024

Changeset file for PR opensearch-project#8788 created/updated

49c049c

AMoo-Miki dismissed joshuali925’s stale review via 49c049c November 4, 2024 20:49

AMoo-Miki force-pushed the new-translations branch from dbe4c40 to 49c049c Compare November 4, 2024 20:49

AMoo-Miki and others added 3 commits November 4, 2024 14:11

[i18n-dev] Allow updating existing localization files when importing …

5aabccc

…with "i18n:integrate" Signed-off-by: Miki <[email protected]>

[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it…

cfc9b96

…-IT, ja-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW Signed-off-by: Miki <[email protected]>

Changeset file for PR opensearch-project#8788 created/updated

63140cb

AMoo-Miki force-pushed the new-translations branch from 49c049c to 63140cb Compare November 4, 2024 22:11

kavilla approved these changes Nov 5, 2024

View reviewed changes

virajsanghvi approved these changes Nov 5, 2024

View reviewed changes

joshuali925 approved these changes Nov 5, 2024

View reviewed changes

AMoo-Miki merged commit 87832f3 into opensearch-project:main Nov 6, 2024
68 of 69 checks passed

opensearch-trigger-bot bot mentioned this pull request Nov 6, 2024

[Backport 2.x] [i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW #8821

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW #8788

[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW #8788

AMoo-Miki commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

codecov bot commented Nov 1, 2024 •

edited

Loading

joshuali925 Nov 1, 2024

AMoo-Miki Nov 4, 2024

joshuali925 Nov 1, 2024

AMoo-Miki Nov 4, 2024

ashwin-pc Nov 2, 2024

AMoo-Miki Nov 4, 2024

AMoo-Miki Nov 4, 2024

kavilla left a comment

virajsanghvi left a comment

AMoo-Miki commented Nov 6, 2024

[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW #8788

[i18n] Add additional translations for de-DE, es-ES, fr-FR, id-ID, it-IT, js-JP, ko-KR, pt-PT, tr-TR, zh-CN, and zh-TW #8788

Conversation

AMoo-Miki commented Nov 1, 2024 • edited Loading

Description

Changelog

Check List

github-actions bot commented Nov 1, 2024

❌ Entry Too Long

github-actions bot commented Nov 1, 2024

❌ Invalid Prefix

codecov bot commented Nov 1, 2024 • edited Loading

Codecov Report

joshuali925 Nov 1, 2024

Choose a reason for hiding this comment

AMoo-Miki Nov 4, 2024

Choose a reason for hiding this comment

joshuali925 Nov 1, 2024

Choose a reason for hiding this comment

AMoo-Miki Nov 4, 2024

Choose a reason for hiding this comment

ashwin-pc Nov 2, 2024

Choose a reason for hiding this comment

AMoo-Miki Nov 4, 2024

Choose a reason for hiding this comment

AMoo-Miki Nov 4, 2024

Choose a reason for hiding this comment

kavilla left a comment

Choose a reason for hiding this comment

virajsanghvi left a comment

Choose a reason for hiding this comment

AMoo-Miki commented Nov 6, 2024

AMoo-Miki commented Nov 1, 2024 •

edited

Loading

codecov bot commented Nov 1, 2024 •

edited

Loading