Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.18] Fix data source info is missing in default query when click Discover from other pages #8794

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 97f4734 from #8583.

…from other pages (#8583)

When we click Discover sidebar from other pages, we don't fetch the data source info and enrich the default dataset, so that some unexpected behavior happens.
Issues Resolved

#8582

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 97f4734)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.85%. Comparing base (6b49593) to head (fb73ff2).
Report is 29 commits behind head on 2.18.

Files with missing lines Patch % Lines
...ry/query_string/dataset_service/dataset_service.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.18    #8794      +/-   ##
==========================================
- Coverage   60.95%   60.85%   -0.10%     
==========================================
  Files        3792     3797       +5     
  Lines       90469    90714     +245     
  Branches    14199    14276      +77     
==========================================
+ Hits        55144    55204      +60     
- Misses      31839    32015     +176     
- Partials     3486     3495       +9     
Flag Coverage Δ
Linux_1 29.06% <0.00%> (-0.04%) ⬇️
Linux_2 56.53% <ø> (-0.01%) ⬇️
Linux_3 37.65% <66.66%> (-0.06%) ⬇️
Linux_4 29.94% <0.00%> (-0.04%) ⬇️
Windows_1 29.07% <0.00%> (-0.04%) ⬇️
Windows_2 56.48% <ø> (-0.01%) ⬇️
Windows_3 37.65% <66.66%> (-0.06%) ⬇️
Windows_4 29.94% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 merged commit 245f920 into 2.18 Nov 12, 2024
69 of 72 checks passed
@github-actions github-actions bot deleted the backport/backport-8583-to-2.18 branch November 12, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset repeat-contributor v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants