[Discover] Fix discover query loading state

[joshuali925]

Description

Duplicated code was introduced by #8565 to run the same logic regardless of if condition, possibly due to merge conflict?

OpenSearch-Dashboards/src/plugins/data/public/query/query_string/language_service/lib/query_result.tsx

Lines 62 to 94 in c8278f3

	if (props.queryStatus.status === ResultStatus.LOADING) {
	const time = Math.floor(elapsedTime / 1000);
	return (
	<EuiButtonEmpty
	color="text"
	size="xs"
	onClick={() => {}}
	isLoading
	data-test-subj="queryResultLoading"
	>
	{i18n.translate('data.query.languageService.queryResults.loadTime', {
	defaultMessage: 'Loading {time} s',
	values: { time },
	})}
	</EuiButtonEmpty>
	);
	}
	const time = Math.floor(elapsedTime / 1000);
	return (
	<EuiButtonEmpty
	color="text"
	size="xs"
	onClick={() => {}}
	isLoading
	data-test-subj="queryResultLoading"
	className="editor__footerItem"
	>
	{i18n.translate('data.query.languageService.queryResults.loadTime', {
	defaultMessage: 'Loading {time} s',
	values: { time },
	})}
	</EuiButtonEmpty>
	);

It causes UI to show loading even when status is not loading. This PR fixes it

Additionally, this PR changes loading behavior to be

1. when there are no results, running the query shows loading in query editor footer and below
2. when there are results, running the query shows loading in query editor footer with previous query results

Issues Resolved

Screenshot

Testing the changes

Changelog

• skip

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (aa60870) to head (3c1a512).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...ublic/application/view_components/canvas/index.tsx	0.00%	4 Missing ⚠️
...ic/application/view_components/utils/use_search.ts	33.33%	2 Missing ⚠️
...query_string/language_service/lib/query_result.tsx	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8832   +/-   ##
=======================================
  Coverage   60.86%   60.87%           
=======================================
  Files        3799     3799           
  Lines       90761    90757    -4     
  Branches    14294    14291    -3     
=======================================
+ Hits        55246    55248    +2     
+ Misses      32005    32000    -5     
+ Partials     3510     3509    -1     

Flag	Coverage Δ
Linux_1	29.05% <0.00%> (+<0.01%)	⬆️
Linux_2	56.39% <ø> (ø)
Linux_3	37.81% <22.22%> (+<0.01%)	⬆️
Linux_4	29.87% <0.00%> (+<0.01%)	⬆️
Windows_1	29.06% <0.00%> (+<0.01%)	⬆️
Windows_2	56.34% <ø> (ø)
Windows_3	37.81% <22.22%> (+<0.01%)	⬆️
Windows_4	29.87% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[abbyhu2000]

Why do we change this logic here? @joshuali925

[joshuali925]

the logic was accidentally reversed due to testing, we want to reset data$ to initial state when two datasets are different (meaning user changed dataset), not when they are the same

[abbyhu2000]

So we wish to always to show loading indicator no matter if the rows are empty or not?

[joshuali925]

yes

[abbyhu2000]

why do we have two different result for loading status now?

[joshuali925]

we want to show results if query finished and results are ready, or if there are previous results while current query is loading