Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to turn extending numeric precision on or off #8837

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add setting to turn extending numeric precision on or off #8837

wants to merge 4 commits into from

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Nov 9, 2024 •
edited
Loading

Description

Add setting to turn extending numeric precision on or off

Screenshot

Screenshot 2024-11-08 at 16-58-25 OpenSearch Dashboards

Changelog

  • feat: Add setting to turn extending numeric precision on or off

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 9, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8837 created/updated
79ec26e
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.89%. Comparing base (ab4e6e8) to head (649366b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8837      +/-   ##
==========================================
+ Coverage   60.85%   60.89%   +0.03%     
==========================================
  Files        3802     3802              
  Lines       91059    91062       +3     
  Branches    14376    14376              
==========================================
+ Hits        55417    55451      +34     
+ Misses      32103    32059      -44     
- Partials     3539     3552      +13
Flag Coverage Δ
Linux_1 29.01% <0.00%> (-0.01%) ⬇️
Linux_2 56.39% <0.00%> (-0.01%) ⬇️
Linux_3 ?
Linux_4 29.00% <0.00%> (-0.01%) ⬇️
Windows_1 29.02% <0.00%> (-0.01%) ⬇️
Windows_2 56.34% <0.00%> (-0.01%) ⬇️
Windows_3 37.93% <100.00%> (+0.06%) ⬆️
Windows_4 29.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla
kavilla reviewed Nov 16, 2024
View reviewed changes
src/plugins/data/common/constants.ts
@@ -108,4 +108,5 @@ export const UI_SETTINGS = {
QUERY_DATAFRAME_HYDRATION_STRATEGY: 'query:dataframe:hydrationStrategy',
SEARCH_QUERY_LANGUAGE_BLOCKLIST: 'search:queryLanguageBlocklist',
NEW_HOME_PAGE: 'home:useNewHomePage',
DATA_WITH_LONG_NUMERALS: 'data:withLongNumerals',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i think i originally did data as well. but then was convinced to use search because then we can group it with the search category. not a strong opinion on this though

kavilla
kavilla previously approved these changes Nov 16, 2024
View reviewed changes
kavilla
kavilla approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my pr caused a conflict on this pr so i just fixed it on github. do you mind verifying miki it's all good?

also one thing i think we should do is move this to the workspace setting or even better yet allow for request options from the query editor would make life a lot easier for developers vs an advanced setting to toggle percision or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMoo-Miki @kavilla