Adjusted source of QueryStringManager functions for flyout. #8864

AWSHurneyt · 2024-11-14T02:52:24Z

Description

Addressed comment Fix template queries loading and update getSampleQuery interface #8848 (comment)
Added try/catch block.

Issues Resolved

Screenshot

Testing the changes

Changelog

skip

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: AWSHurneyt <[email protected]>

github-actions · 2024-11-14T02:53:02Z

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8864.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

codecov · 2024-11-14T03:07:21Z

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (c20c041) to head (c6e6441).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...ui/saved_query_flyouts/open_saved_query_flyout.tsx	47.05%	7 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8864      +/-   ##
==========================================
+ Coverage   60.92%   60.94%   +0.01%     
==========================================
  Files        3800     3800              
  Lines       90841    90881      +40     
  Branches    14313    14323      +10     
==========================================
+ Hits        55343    55384      +41     
+ Misses      31978    31968      -10     
- Partials     3520     3529       +9

Flag	Coverage Δ
Linux_1	`29.01% <ø> (-0.02%)`	⬇️
Linux_2	`56.39% <ø> (ø)`
Linux_3	`37.93% <47.05%> (+0.06%)`	⬆️
Linux_4	`29.00% <ø> (-0.90%)`	⬇️
Windows_1	`29.02% <ø> (-0.04%)`	⬇️
Windows_2	`56.34% <ø> (ø)`
Windows_3	`37.92% <47.05%> (+0.06%)`	⬆️
Windows_4	`29.00% <ø> (-0.90%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/data/public/ui/search_bar/search_bar.tsx

src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx

Signed-off-by: AWSHurneyt <[email protected]>

kavilla · 2024-11-14T21:11:41Z

thank you so much! one more thing, we use a changelog bot to generate changelog fragment and then release notes. do you mind updating the PR description. in this case i think it can be skip as this is fixing something that hasn't been released yet. but i'll leave that up to you. you might need to install the bot as well

#8864 (comment)

i think regardless it might fail the ci check because it's detecting commits t hat had a changelog fragment

github-actions · 2024-11-14T22:50:13Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

kavilla · 2024-11-14T23:02:54Z

src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx

-        setSavedQueries(mutableSavedQueries);
+        const allQueries = await savedQueryService.getAllSavedQueries();
+        const mutableSavedQueries = allQueries.filter((q) => !q.attributes.isTemplate);
+        if (currentTabIdRef.current === 'mutable-saved-queries') {


is this required? line 89 should be covering it right?

@jowg-amazon could you clarify?

We were noticing that the getAllSavedQueries call can take a little while to return. If a user switches tabs before this call is finished, we were seeing that setSavedQueries(mutableSavedQueries) was overwriting the saved queries incorrectly. This check makes sure that we're still on the mutable saved queries tab.

instead of just have a state variable that sets a boolean if it hasTemplateQueries, why don't we just have a state variable for templateQueries and a state variable mutableSavedQueries.

Or even more so just set saved queries to all queries and then in the component if the selected tab is template-saved-queries you filter out all the saved queries not matching template-saved-queries etc.

Signed-off-by: AWSHurneyt <[email protected]>

kavilla · 2024-11-15T08:21:02Z

src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx

      if (currentTabIdRef.current === 'mutable-saved-queries') {
-        setSavedQueries(mutableSavedQueries);
+        const allQueries = await savedQueryService.getAllSavedQueries();


we should refactor this component. we shouldn't need to fire a request to get all saved queries if the user opened saved queries and then switched to template queries and then switch back to saved queries and fire a request. we already have their saved queries

Yes i think we already noticed the queries taking way longer to show up than they should

ashwin-pc · 2024-11-15T15:42:57Z

src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx

      if (currentTabIdRef.current === 'mutable-saved-queries') {
-        setSavedQueries(mutableSavedQueries);
+        const allQueries = await savedQueryService.getAllSavedQueries();


Yes i think we already noticed the queries taking way longer to show up than they should

AWSHurneyt added 2 commits November 13, 2024 17:07

Change origin of query string management functions.

da36888

Signed-off-by: AWSHurneyt <[email protected]>

Added try/catch block.

9867fe8

Signed-off-by: AWSHurneyt <[email protected]>

github-actions bot added the first-time-contributor label Nov 14, 2024

AWSHurneyt mentioned this pull request Nov 14, 2024

Fix template queries loading and update getSampleQuery interface #8848

Merged

7 tasks

github-actions bot added the failed changeset label Nov 14, 2024

kavilla reviewed Nov 14, 2024

View reviewed changes

src/plugins/data/public/ui/search_bar/search_bar.tsx Outdated Show resolved Hide resolved

kavilla reviewed Nov 14, 2024

View reviewed changes

src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx Outdated Show resolved Hide resolved

AWSHurneyt added 5 commits November 14, 2024 10:41

Changed source of query string management functions.

b0a31bc

Signed-off-by: AWSHurneyt <[email protected]>

Fixed typo.

654fa32

Signed-off-by: AWSHurneyt <[email protected]>

Fixed import.

7864ebd

Signed-off-by: AWSHurneyt <[email protected]>

Fix lint errors.

b4e32f7

Signed-off-by: AWSHurneyt <[email protected]>

Fixed lint error.

3013ed8

Signed-off-by: AWSHurneyt <[email protected]>

kavilla added backport 2.x discover for discover reinvent discover-next labels Nov 14, 2024

github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Nov 14, 2024

kavilla reviewed Nov 14, 2024

View reviewed changes

Fixed test mocks.

c6e6441

Signed-off-by: AWSHurneyt <[email protected]>

kavilla reviewed Nov 15, 2024

View reviewed changes

kavilla approved these changes Nov 15, 2024

View reviewed changes

ashwin-pc approved these changes Nov 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjusted source of QueryStringManager functions for flyout. #8864

Adjusted source of QueryStringManager functions for flyout. #8864

AWSHurneyt commented Nov 14, 2024 •

edited

Loading

github-actions bot commented Nov 14, 2024

codecov bot commented Nov 14, 2024 •

edited

Loading

kavilla commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

kavilla Nov 14, 2024

AWSHurneyt Nov 14, 2024 •

edited

Loading

jowg-amazon Nov 15, 2024

kavilla Nov 15, 2024

kavilla Nov 15, 2024

ashwin-pc Nov 15, 2024

ashwin-pc Nov 15, 2024

Adjusted source of QueryStringManager functions for flyout. #8864

Are you sure you want to change the base?

Adjusted source of QueryStringManager functions for flyout. #8864

Conversation

AWSHurneyt commented Nov 14, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Nov 14, 2024

ℹ️ Manual Changeset Creation Reminder

codecov bot commented Nov 14, 2024 • edited Loading

Codecov Report

kavilla commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

❌ Changelog Entry Missing Hyphen

kavilla Nov 14, 2024

Choose a reason for hiding this comment

AWSHurneyt Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

jowg-amazon Nov 15, 2024

Choose a reason for hiding this comment

kavilla Nov 15, 2024

Choose a reason for hiding this comment

kavilla Nov 15, 2024

Choose a reason for hiding this comment

ashwin-pc Nov 15, 2024

Choose a reason for hiding this comment

ashwin-pc Nov 15, 2024

Choose a reason for hiding this comment

AWSHurneyt commented Nov 14, 2024 •

edited

Loading

codecov bot commented Nov 14, 2024 •

edited

Loading

AWSHurneyt Nov 14, 2024 •

edited

Loading