[Workspace]fix: recent item links are not correctly constructed #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9275 +/- ##
=======================================
Coverage 61.68% 61.68%
=======================================
Files 3816 3816
Lines 91693 91693
Branches 14516 14516
=======================================
+ Hits 56557 56559 +2
+ Misses 31510 31509 -1
+ Partials 3626 3625 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
approved these changes
Jan 26, 2025
ruanyl
approved these changes
Jan 26, 2025
Hailong-am
approved these changes
Jan 26, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
* fix: recent item links are not correctly constructed Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #9275 created/updated --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1ac056a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jan 27, 2025
… (#9276) * fix: recent item links are not correctly constructed * Changeset file for PR #9275 created/updated --------- (cherry picked from commit 1ac056a) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When constructing the link for recent items, workspace feature flag is required. This PR is to pass workspace feature flag to all the places calling
createRecentNavLink.Issues Resolved
Screenshot
Before fix
20250126155211735.mp4
After fix
20250126155100110.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration