-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] refactor all tests to be consistent across different source codes #9319
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Justin Kim <[email protected]>
❌ Invalid Additional Prefix With Skip Entry OptionIf your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9319 +/- ##
=======================================
Coverage 61.70% 61.71%
=======================================
Files 3816 3816
Lines 91829 91829
Branches 14543 14543
=======================================
+ Hits 56666 56668 +2
+ Misses 31507 31506 -1
+ Partials 3656 3655 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Kim <[email protected]>
@@ -266,3 +169,117 @@ Cypress.Commands.add('setRelativeTopNavDate', (time, timeUnit) => { | |||
cy.getElementByTestId('superDatePickerRelativeDateInputUnitSelector').select(timeUnit); | |||
cy.getElementByTestId('querySubmitButton').click(); | |||
}); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly separates a normal command from an OSD command ? I feel we should have some criteria for segregating between the 2 commands also, if possible put them in separate files. This will help to delineate them and put forth a procedure for future contributors to adhere to .
Description
Refactor all tests so that code can be consistent across different source codes.
Cypress.env('SOURCE_CODE')
BREAKING CHANGES:
SECONDARY_ENGINE.url
->PATHS.SECONDARY_ENGINE
prepareTestSuite()
functiongetRandomizedDatasourceName()
is removed. UseDATASOURCE_NAME
insteadcy.deleteIndex()
->cy.osd.deleteIndex()
cy.addDataSource()
->cy.osd.addDataSource()
cy.deleteDataSourceByName()
->cy.osd.deleteDataSourceByName()
cy.deleteAllDataSources()
->cy.osd.deleteAllDataSources()
cy.osd.openWorkspaceDashboard
->cy.openWorkspaceDashboard()
Changelog
Check List
yarn test:jest
yarn test:jest_integration