Remove composeBuild fixture tasks when docker support not found #14357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
finnegancarroll
force-pushed
the
testfilt
branch
from
3ae436d
to
776e176
Compare
finnegancarroll
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
❌ Gradle check result for 776e176: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3ae436d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Jun 14, 2024
|
Flaky test org.opensearch.cache.common.tier.TieredSpilloverCacheStatsIT.testIndicesLevelAggregation #14300 |
Signed-off-by: Finn Carroll <[email protected]>
finnegancarroll
force-pushed
the
testfilt
branch
from
776e176
to
bc09a58
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14357 +/- ##
============================================
+ Coverage 71.42% 71.73% +0.31%
- Complexity 59978 62084 +2106
============================================
Files 4985 5117 +132
Lines 282275 291713 +9438
Branches 40946 42168 +1222
============================================
+ Hits 201603 209250 +7647
- Misses 63999 65189 +1190
- Partials 16673 17274 +601 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Jun 18, 2024
buildSrc/src/main/java/org/opensearch/gradle/testfixtures/TestFixturesPlugin.java
Show resolved
Hide resolved
reta
added
skip-changelog
Build
reta
approved these changes
Jun 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
Signed-off-by: Finn Carroll <[email protected]> (cherry picked from commit f8213b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jun 18, 2024
(cherry picked from commit f8213b8) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jun 19, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…14357) Signed-off-by: Finn Carroll <[email protected]>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…14357) (opensearch-project#14440) (cherry picked from commit f8213b8) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…14357) Signed-off-by: Finn Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
./gradlew testcomposeBuild task is not skipped on systems without docker cli.Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.