-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow maintainers to opt-out of perf workflow approval requests #15468
Allow maintainers to opt-out of perf workflow approval requests #15468
Conversation
Tweak the logic for the maintainer list that becomes the assigned approvers on GitHub issues so that maintainers can opt out of this approval process. Signed-off-by: Peter Nied <[email protected]>
… for other maintainers to opt-out if desired. Signed-off-by: Peter Nied <[email protected]>
@peternied thanks for opening it, do you think we could rely on the same approach as you did for
By default, we could include all maintainers in the |
I like this better too! |
Signed-off-by: Peter Nied <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea @reta to reuse the codeowners. I've made this update, but I need to validate that I didn't break this workflow with the new action.
It has been over a week since I thought about getting myself removed from the perf workflow approvals - and even with code complete coming up this hasn't been on the front of my mind so I'm going to set this down. Mostly this is because I don't have a good way to be sure that I'm not breaking the workflow until after this change is merged :/ If this is bugging folks other than myself maybe we can have someone take up this PR or we can collaborate on getting this out, created an issue [1] to make sure this notion isn't lost when I close out this PR. |
Description
Tweak the logic for the maintainer list that becomes the assigned approvers on GitHub issues so that maintainers can opt out of this approval process.
Related Issues
Check List
Functionality includes testing.API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.