Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.x [Workload Management] QueryGroup Stats API Logic #16274

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Backport 2.x [Workload Management] QueryGroup Stats API Logic #16274

merged 3 commits into from
Oct 10, 2024

Conversation

ruai0511
Copy link
Contributor

Backport #15777

@ruai0511
[Workload Management] QueryGroup Stats API Logic (opensearch-project#…
7ce85e2 
…15777)

Signed-off-by: Ruirui Zhang <[email protected]>
* changelog
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* add tests
Signed-off-by: Ruirui Zhang <[email protected]>

* modify uri
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on comments
Signed-off-by: Ruirui Zhang <[email protected]>

* changelog
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* add tests
Signed-off-by: Ruirui Zhang <[email protected]>

* modify uri
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on comments
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on comments
Signed-off-by: Ruirui Zhang <[email protected]>

* revise
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* changelog
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* add tests
Signed-off-by: Ruirui Zhang <[email protected]>

* modify uri
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on comments
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on comments
Signed-off-by: Ruirui Zhang <[email protected]>

* git pull
Signed-off-by: Ruirui Zhang <[email protected]>

* rebase
Signed-off-by: Ruirui Zhang <[email protected]>

* encapsulate querygroupstats in wlmstats
Signed-off-by: Ruirui Zhang <[email protected]>

* fix UT
Signed-off-by: Ruirui Zhang <[email protected]>
(cherry picked from commit b2253f1)
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7ce85e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ruai0511 ruai0511 force-pushed the backport/backport-15777-to-2.x branch from dbc7c71 to c169973 Compare October 10, 2024 21:46
@ruai0511
spotless apply
fd9505b 
Signed-off-by: Ruirui Zhang <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for fd9505b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.95726% with 41 lines in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (589f42c) to head (fd9505b).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/opensearch/wlm/QueryGroupService.java 20.00% 15 Missing and 5 partials ⚠️
...arch/action/admin/cluster/wlm/WlmStatsRequest.java 66.66% 6 Missing ⚠️
...ion/admin/cluster/wlm/TransportWlmStatsAction.java 75.00% 5 Missing ⚠️
.../rest/action/admin/cluster/RestWlmStatsAction.java 44.44% 5 Missing ⚠️
...rch/action/admin/cluster/wlm/WlmStatsResponse.java 90.47% 2 Missing ⚠️
.../org/opensearch/client/support/AbstractClient.java 0.00% 2 Missing ⚠️
...java/org/opensearch/wlm/stats/QueryGroupStats.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16274      +/-   ##
============================================
+ Coverage     71.71%   71.74%   +0.02%     
- Complexity    64985    65016      +31     
============================================
  Files          5296     5302       +6     
  Lines        303765   303876     +111     
  Branches      44182    44193      +11     
============================================
+ Hits         217848   218009     +161     
+ Misses        67800    67668     -132     
- Partials      18117    18199      +82

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit c95404b into opensearch-project:2.x Oct 10, 2024
35 of 36 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeshkr419 sandeshkr419 sandeshkr419 approved these changes

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruai0511 @jainankitk @sandeshkr419