Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove ApproximateIndexOrDocValuesQuery #16291

Merged
merged 1 commit into from
Oct 14, 2024

Commits on Oct 11, 2024

  1. Remove ApproximateIndexOrDocValuesQuery (#16273)

    Looking into the query approximation framework, I realized that we don't
    actually need ApproximateIndexOrDocValuesQuery. We already have
    ApproximateScoreQuery that is able to choose between the approximate
    query and the original query.
    
    Assuming the range query is over an indexed field, it is (potentially)
    possible to approximate. If there are doc values, then the original
    query will be an IndexOrDocValuesQuery. Otherwise, it will just be a
    PointRangeQuery.  Either way, we can wrap the original query into a
    generic ApproximateScoreQuery along with the approximate query. The
    approximation logic doesn't need to be specialized to the
    IndexOrDocValue case.
    
    ---------
    
    Signed-off-by: Michael Froh <[email protected]>
    (cherry picked from commit 53c9ddf)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bd2805b View commit details
    Browse the repository at this point in the history