Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] star tree file formats refactoring and fixing offset bug (#15975) #16302

Closed
wants to merge 1 commit into from

Conversation

bharath-techie
Copy link
Contributor

Description

Backport of #15975

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for f7eeb81: SUCCESS

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 77.04918% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (5947002) to head (f7eeb81).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...be/startree/utils/SequentialDocValuesIterator.java 68.75% 2 Missing and 3 partials ⚠️
...cube/startree/builder/StarTreeDocsFileManager.java 50.00% 1 Missing and 2 partials ⚠️
...eindex/datacube/startree/index/StarTreeValues.java 76.92% 1 Missing and 2 partials ⚠️
...tartree/utils/iterator/StarTreeValuesIterator.java 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16302      +/-   ##
============================================
+ Coverage     71.74%   71.80%   +0.06%     
- Complexity    65022    65061      +39     
============================================
  Files          5302     5304       +2     
  Lines        303866   303859       -7     
  Branches      44192    44190       -2     
============================================
+ Hits         218012   218200     +188     
+ Misses        67648    67462     -186     
+ Partials      18206    18197       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate of #15991, already merged. Rebasing this should create an empty commit.

@bharath-techie
Copy link
Contributor Author

@dbwiddis
Ah sorry I thought it didn't get merged, thanks closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants