Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fixed inefficient Stream API call chains ending with count() (#15386) #16361

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[Backport 2.x] Fixed inefficient Stream API call chains ending with count() (#15386) #16361

merged 2 commits into from
Oct 22, 2024

Conversation

dbwiddis
Copy link
Member

Backport 1a7018a from #15386

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2014527: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2014527: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2014527: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2014527: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 17, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 2014527: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (3ef3455) to head (dab9820).
Report is 14 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../java/org/opensearch/percolator/QueryAnalyzer.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16361      +/-   ##
============================================
+ Coverage     71.78%   71.84%   +0.06%     
- Complexity    65079    65110      +31     
============================================
  Files          5305     5305              
  Lines        304146   304150       +4     
  Branches      44232    44234       +2     
============================================
+ Hits         218317   218511     +194     
+ Misses        67648    67491     -157     
+ Partials      18181    18148      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dk2k @dbwiddis
Fixed inefficient Stream API call chains ending with count() (opensea…
64d95b9 
…rch-project#15386)

* Fixed inefficient Stream API call chains ending with count()

Signed-off-by: Dmitry Kryukov <[email protected]>

* Refactored method minTermLength() as per @sandeshkr419's advice

Signed-off-by: Dmitry Kryukov <[email protected]>

* Added a line in CHANGELOG.md

Signed-off-by: Dmitry Kryukov <[email protected]>

---------

Signed-off-by: Dmitry Kryukov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 64d95b9: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for dab9820: SUCCESS

@owaiskazi19 owaiskazi19 merged commit 0f110e8 into opensearch-project:2.x Oct 22, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbwiddis @owaiskazi19 @dk2k