Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Make Remote Publication a dynamic setting (#15937) #16362

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[Backport 2.x] Make Remote Publication a dynamic setting (#15937) #16362

merged 2 commits into from
Oct 17, 2024

Conversation

shiv0408
Copy link
Member

cherry-pick 0c3e3c0 from #15937

@shiv0408
Make Remote Publication a dynamic setting (opensearch-project#15937)
7f216a2 
* Make Remote Publication a dynamic setting

Signed-off-by: Shivansh Arora <[email protected]>
Co-authored-by: Sooraj Sinha <[email protected]>
(cherry picked from commit 0c3e3c0)
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7f216a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0196250: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

Failing tests are marked flaky:

org.opensearch.remotestore.RemoteRestoreSnapshotIT.testConcurrentV1SnapshotAndV2RepoSettingUpdate - #14324
org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString_FailOpenEnabled - #15843

@shiv0408
remove IT added in another PR
8403156 
Signed-off-by: Shivansh Arora <[email protected]>
@shiv0408 shiv0408 force-pushed the backport/backport-15937-to-2.x branch from 0196250 to 8403156 Compare October 17, 2024 10:09
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8403156: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 closed this Oct 17, 2024
@shiv0408 shiv0408 reopened this Oct 17, 2024
This was referenced Oct 16, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8403156: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

Flaky UT:
org.opensearch.cluster.routing.allocation.AllocationConstraintsTests.testAllConstraints - #15831

@shiv0408 shiv0408 closed this Oct 17, 2024
@shiv0408 shiv0408 reopened this Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 8403156: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (40e4a54) to head (8403156).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 66.66% 1 Missing and 5 partials ⚠️
...ting/remote/InternalRemoteRoutingTableService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16362      +/-   ##
============================================
+ Coverage     71.81%   71.85%   +0.04%     
- Complexity    65072    65100      +28     
============================================
  Files          5305     5304       -1     
  Lines        304056   304059       +3     
  Branches      44219    44219              
============================================
+ Hits         218356   218485     +129     
+ Misses        67500    67357     -143     
- Partials      18200    18217      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit df6c12b into opensearch-project:2.x Oct 17, 2024
105 of 111 checks passed
@shiv0408 shiv0408 deleted the backport/backport-15937-to-2.x branch October 17, 2024 14:21
This was referenced Oct 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiv0408 @shwetathareja @Bukhtawar