Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to unmapped fields in metric aggregation factory #16481

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

expani
Copy link
Contributor

@expani expani commented Oct 25, 2024

Description

Handling empty field context for fields absent in the index.

Related Issues

Resolves #16473

Copy link
Contributor

❌ Gradle check result for 1f8dcc6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419
Copy link
Contributor

@expani Thanks for debugging this. Can you please add a unit test case and move this out of draft state.

Copy link
Contributor

✅ Gradle check result for 51eb573: SUCCESS

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.13%. Comparing base (10873f1) to head (51eb573).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...x/datacube/startree/utils/StarTreeQueryHelper.java 0.00% 0 Missing and 1 partial ⚠️
...gations/support/ValuesSourceAggregatorFactory.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16481      +/-   ##
============================================
- Coverage     72.15%   72.13%   -0.02%     
- Complexity    65145    65172      +27     
============================================
  Files          5315     5318       +3     
  Lines        303573   303781     +208     
  Branches      43925    43951      +26     
============================================
+ Hits         219039   219136      +97     
- Misses        66587    66747     +160     
+ Partials      17947    17898      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Search:Aggregations Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid Field Names in Metric Aggregation Queries that use star tree returns 500 Internal Server Error
2 participants