Fix stale index deletion in snapshots for hashed prefix path type #16617
+76
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Singh <[email protected]>
ashking94
force-pushed
the
fix-stale-cleanup-hashed-prefix
branch
from
fb23dc0
to
706710c
Compare
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
ashking94
commented
Nov 11, 2024
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
ashking94
force-pushed
the
fix-stale-cleanup-hashed-prefix
branch
from
165deac
to
8d819de
Compare
|
❌ Gradle check result for 8d819de: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ashish Singh <[email protected]>
ashking94
force-pushed
the
fix-stale-cleanup-hashed-prefix
branch
from
8d819de
to
c172683
Compare
|
❌ Gradle check result for c172683: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ashking94
commented
Nov 12, 2024
server/src/main/java/org/opensearch/snapshots/SnapshotShardPaths.java
Outdated
Show resolved
Hide resolved
gbbafna
reviewed
Nov 12, 2024
server/src/main/java/org/opensearch/snapshots/SnapshotShardPaths.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashish Singh <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16617 +/- ##
============================================
- Coverage 72.15% 72.07% -0.09%
+ Complexity 65145 65043 -102
============================================
Files 5315 5315
Lines 303573 303590 +17
Branches 43925 43928 +3
============================================
- Hits 219039 218802 -237
- Misses 66587 66863 +276
+ Partials 17947 17925 -22 ☔ View full report in Codecov by Sentry. |
gbbafna
reviewed
Nov 13, 2024
gbbafna
approved these changes
Nov 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…6617) Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit 4cce608) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
pushed a commit
that referenced
this pull request
Nov 14, 2024
…6617) (#16637) (cherry picked from commit 4cce608) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the index name has
.period in it, then the stale index deletion fails as the period character interferes with the delimiter (which is also period character) by giving more parts than expected during theString.split(".")operation while interpreting the snapshot shards path file. The fix is to handle the variables after the index name as relative from last than from 0. This fixes the problem.Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.