-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added transport action for bulk async shard fetch for primary shards #8218
Added transport action for bulk async shard fetch for primary shards #8218
Conversation
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sudarshan-baliga for creating a smaller PR.
Partially gone through it.
server/src/main/java/org/opensearch/gateway/AsyncShardsFetchPerNode.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/AsyncShardsFetchPerNode.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesBulkListGatewayStartedShards.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesBulkListGatewayStartedShards.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesBulkListGatewayStartedShards.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesBulkListGatewayStartedShards.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesGatewayStartedShardHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesGatewayStartedShardHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/AsyncShardsFetchPerNode.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
ea48cb3
to
7a60156
Compare
…roject#8218 Modify async replica shard fetch to use helper functions Signed-off-by: sudarshan baliga <[email protected]>
Thanks for approval @shwetathareja! |
❌ Gradle check result for 1dbd248: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f8d8a6a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for d1e90a1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Build failure due to following already identified flaky test in #10006.
|
Signed-off-by: Shivansh Arora <[email protected]>
❕ Gradle check result for 8f113fc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…pensearch-project#8218) * Added transport action for bulk async shard fetch for primary shards Signed-off-by: sudarshan baliga <[email protected]> Co-authored-by: Shivansh Arora <[email protected]>
* Add batch async shard fetch transport action for replica Signed-off-by: sudarshan baliga <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Aman Khare <[email protected]>
…pensearch-project#8218) * Added transport action for bulk async shard fetch for primary shards Signed-off-by: sudarshan baliga <[email protected]> Co-authored-by: Shivansh Arora <[email protected]>
…roject#8218 (opensearch-project#8356) * Add batch async shard fetch transport action for replica Signed-off-by: sudarshan baliga <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Aman Khare <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-8218-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8cb4bb4c1776aaee3c4065c5a6b43e86a1e52daa
# Push it to GitHub
git push --set-upstream origin backport/backport-8218-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…pensearch-project#8218) * Added transport action for bulk async shard fetch for primary shards Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 8cb4bb4) Signed-off-by: Shivansh Arora <[email protected]>
…primary shards (#12759) * Added transport action for bulk async shard fetch for primary shards (#8218) * Added transport action for bulk async shard fetch for primary shards Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 8cb4bb4) Signed-off-by: Shivansh Arora <[email protected]>
…roject#8218 (opensearch-project#8356) * Add batch async shard fetch transport action for replica Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 12115d1)
#12770) * Add batch async shard fetch transport action for replica Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 12115d1)
…pensearch-project#8218) * Added transport action for bulk async shard fetch for primary shards Signed-off-by: sudarshan baliga <[email protected]> Co-authored-by: Shivansh Arora <[email protected]>
…roject#8218 (opensearch-project#8356) * Add batch async shard fetch transport action for replica Signed-off-by: sudarshan baliga <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Aman Khare <[email protected]>
Description
This PR for adding the transport action for the async fetching of the shard information for bulk of shards from the nodes in a single request per node. Code is inspired by the existing transport action TransportNodesListGatewayStartedShards.java which fetches just one shard information from the node per request.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.