-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use smaller and compressed varients of buttons and form components #1010
Conversation
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Also: * Clean up some code Signed-off-by: Miki <[email protected]>
Also: * Clean up some code Signed-off-by: Miki <[email protected]>
@AMoo-Miki We have issue #415 to track known flaky cypress tests. Looks like the tests failing in this PR are not mentioned in that issue. I'm wondering whether the changes caused some kind of regression, or whether the tests just need to be refactored to reflect the changes. Do they pass locally for you? |
In one of the cases, the test starts populating the index pattern but is interrupted by the cluster being added to the page and then the index pattern is left blank.
query_level_monitor_spec.js.mp4
|
Apparently, these have been failing for some time now: https://github.com/opensearch-project/alerting-dashboards-plugin/actions/workflows/cypress-workflow.yml |
The composite monitor spec does have a flaky test, but it looks like it passed in this PR from a few days ago. Which was the most recent merge to I'm rerunning the checks in PR 1010 now to see if maybe the tests are flaky. |
@AWSHurneyt The same 3 failed in https://github.com/opensearch-project/alerting-dashboards-plugin/actions/runs/10050410663/job/27778265636 which has no changes. |
…1010) * Use EuiSmallButton Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonIcon Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonEmpty Signed-off-by: Miki <[email protected]> * Use EuiCompressedFormRow Signed-off-by: Miki <[email protected]> * Use EuiCompressedField* Signed-off-by: Miki <[email protected]> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <[email protected]> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedSwitch Signed-off-by: Miki <[email protected]> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <[email protected]> * Use EuiCompressedComboBox Signed-off-by: Miki <[email protected]> * Undo unnecessary EuiSmallButton* uses Signed-off-by: Miki <[email protected]> * Introduce `compressed` FrequencyPicker` and `DateRangePicker` Also: * Clean up some code Signed-off-by: Miki <[email protected]> * Update snapshots and fix errors Also: * Clean up some code Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit cc8b959) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.16
# Create a new branch
git switch --create backport-1010-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cc8b95964616f23642ca88fc0564cb2fa3840eaf
# Push it to GitHub
git push --set-upstream origin backport-1010-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.16 Then, create a pull request where the |
Auto backport to 2.16 failed. Will try to auto backport the 2.x PR (#1017). |
…1010) (#1017) * Use EuiSmallButton * Use EuiSmallButtonIcon * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedSwitch * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Undo unnecessary EuiSmallButton* uses * Introduce `compressed` FrequencyPicker` and `DateRangePicker` Also: * Clean up some code * Update snapshots and fix errors Also: * Clean up some code --------- (cherry picked from commit cc8b959) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#1010) * Use EuiSmallButton Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonIcon Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonEmpty Signed-off-by: Miki <[email protected]> * Use EuiCompressedFormRow Signed-off-by: Miki <[email protected]> * Use EuiCompressedField* Signed-off-by: Miki <[email protected]> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <[email protected]> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedSwitch Signed-off-by: Miki <[email protected]> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <[email protected]> * Use EuiCompressedComboBox Signed-off-by: Miki <[email protected]> * Undo unnecessary EuiSmallButton* uses Signed-off-by: Miki <[email protected]> * Introduce `compressed` FrequencyPicker` and `DateRangePicker` Also: * Clean up some code Signed-off-by: Miki <[email protected]> * Update snapshots and fix errors Also: * Clean up some code Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit cc8b959) Signed-off-by: Miki <[email protected]>
…1010) (#1022) * Use EuiSmallButton * Use EuiSmallButtonIcon * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedSwitch * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Undo unnecessary EuiSmallButton* uses * Introduce `compressed` FrequencyPicker` and `DateRangePicker` Also: * Clean up some code * Update snapshots and fix errors Also: * Clean up some code --------- (cherry picked from commit cc8b959) Signed-off-by: Miki <[email protected]>
Description
Replace instances of
EuiButton
that don't have an explicit sizing attribute toEuiSmallButton*
.Replace instances of
Eui<form elements>
that don't have density attributes toEuiCompressed<form elements>
.Add and use
compressed
to DateRangePicker and FrequencyPicker.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.