Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller and compressed varients of buttons and form components #1010

Merged
merged 14 commits into from
Jul 23, 2024

Conversation

AMoo-Miki
Copy link
Contributor

@AMoo-Miki AMoo-Miki commented Jul 22, 2024

Description

Replace instances of EuiButton that don't have an explicit sizing attribute to EuiSmallButton*.
Replace instances of Eui<form elements> that don't have density attributes to EuiCompressed<form elements>.
Add and use compressed to DateRangePicker and FrequencyPicker.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Also:
* Clean up some code

Signed-off-by: Miki <[email protected]>
Also:
* Clean up some code

Signed-off-by: Miki <[email protected]>
@AWSHurneyt
Copy link
Collaborator

@AMoo-Miki We have issue #415 to track known flaky cypress tests. Looks like the tests failing in this PR are not mentioned in that issue. I'm wondering whether the changes caused some kind of regression, or whether the tests just need to be refactored to reflect the changes.

Do they pass locally for you?

@AMoo-Miki
Copy link
Contributor Author

AMoo-Miki commented Jul 22, 2024

@AMoo-Miki We have issue #415 to track known flaky cypress tests. Looks like the tests failing in this PR are not mentioned in that issue. I'm wondering whether the changes caused some kind of regression, or whether the tests just need to be refactored to reflect the changes.

Do they pass locally for you?

In one of the cases, the test starts populating the index pattern but is interrupted by the cluster being added to the page and then the index pattern is left blank.

  • Query-Level Monitors > can have triggers > with names that contain periods
query_level_monitor_spec.js.mp4
  • Query-Level Monitors > can be updated > to have multiple indices
    The same index pattern field is involved here too and while the video doesn't capture the interaction since it is below the viewport, the message indicates the cluster selection is causing trouble.

@AMoo-Miki
Copy link
Contributor Author

Apparently, these have been failing for some time now: https://github.com/opensearch-project/alerting-dashboards-plugin/actions/workflows/cypress-workflow.yml

@AWSHurneyt
Copy link
Collaborator

The composite monitor spec does have a flaky test, but it looks like it passed in this PR from a few days ago. Which was the most recent merge to main before today.
https://github.com/opensearch-project/alerting-dashboards-plugin/pull/1004/checks

I'm rerunning the checks in PR 1010 now to see if maybe the tests are flaky.

@AMoo-Miki
Copy link
Contributor Author

@AWSHurneyt AWSHurneyt merged commit cc8b959 into opensearch-project:main Jul 23, 2024
11 of 15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
…1010)

* Use EuiSmallButton

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonIcon

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonEmpty

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedFormRow

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedField*

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSelect and EuiCompressedSuperSelect

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedRadio and EuiCompressedRadioGroup

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSwitch

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedEuiTextArea

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedComboBox

Signed-off-by: Miki <[email protected]>

* Undo unnecessary EuiSmallButton* uses

Signed-off-by: Miki <[email protected]>

* Introduce `compressed` FrequencyPicker` and `DateRangePicker`

Also:
* Clean up some code

Signed-off-by: Miki <[email protected]>

* Update snapshots and fix errors

Also:
* Clean up some code

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
(cherry picked from commit cc8b959)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.16
# Create a new branch
git switch --create backport-1010-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cc8b95964616f23642ca88fc0564cb2fa3840eaf
# Push it to GitHub
git push --set-upstream origin backport-1010-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport-1010-to-2.16.

@AWSHurneyt
Copy link
Collaborator

Auto backport to 2.16 failed. Will try to auto backport the 2.x PR (#1017).

AWSHurneyt pushed a commit that referenced this pull request Jul 24, 2024
…1010) (#1017)

* Use EuiSmallButton



* Use EuiSmallButtonIcon



* Use EuiSmallButtonEmpty



* Use EuiCompressedFormRow



* Use EuiCompressedField*



* Use EuiCompressedSelect and EuiCompressedSuperSelect



* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup



* Use EuiCompressedRadio and EuiCompressedRadioGroup



* Use EuiCompressedSwitch



* Use EuiCompressedEuiTextArea



* Use EuiCompressedComboBox



* Undo unnecessary EuiSmallButton* uses



* Introduce `compressed` FrequencyPicker` and `DateRangePicker`

Also:
* Clean up some code



* Update snapshots and fix errors

Also:
* Clean up some code



---------


(cherry picked from commit cc8b959)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki added a commit to AMoo-Miki/alerting-dashboards-plugin that referenced this pull request Jul 24, 2024
…pensearch-project#1010)

* Use EuiSmallButton

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonIcon

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonEmpty

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedFormRow

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedField*

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSelect and EuiCompressedSuperSelect

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedRadio and EuiCompressedRadioGroup

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSwitch

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedEuiTextArea

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedComboBox

Signed-off-by: Miki <[email protected]>

* Undo unnecessary EuiSmallButton* uses

Signed-off-by: Miki <[email protected]>

* Introduce `compressed` FrequencyPicker` and `DateRangePicker`

Also:
* Clean up some code

Signed-off-by: Miki <[email protected]>

* Update snapshots and fix errors

Also:
* Clean up some code

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>

(cherry picked from commit cc8b959)
Signed-off-by: Miki <[email protected]>
riysaxen-amzn pushed a commit that referenced this pull request Jul 24, 2024
…1010) (#1022)

* Use EuiSmallButton



* Use EuiSmallButtonIcon



* Use EuiSmallButtonEmpty



* Use EuiCompressedFormRow



* Use EuiCompressedField*



* Use EuiCompressedSelect and EuiCompressedSuperSelect



* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup



* Use EuiCompressedRadio and EuiCompressedRadioGroup



* Use EuiCompressedSwitch



* Use EuiCompressedEuiTextArea



* Use EuiCompressedComboBox



* Undo unnecessary EuiSmallButton* uses



* Introduce `compressed` FrequencyPicker` and `DateRangePicker`

Also:
* Clean up some code



* Update snapshots and fix errors

Also:
* Clean up some code



---------



(cherry picked from commit cc8b959)

Signed-off-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants