[Backport 2.17] Fit and Finish UX Fixes #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* remove horizontal line below search bar Signed-off-by: Joanne Wang <[email protected]> * space between header and panel 16px and space around table 16px Signed-off-by: Joanne Wang <[email protected]> * fix 16px around table and search bar Signed-off-by: Joanne Wang <[email protected]> * remove pagination from top of table Signed-off-by: Joanne Wang <[email protected]> * add button to create monitor Signed-off-by: Joanne Wang <[email protected]> * add tooltip to delete Signed-off-by: Joanne Wang <[email protected]> * remove space on trash icon Signed-off-by: Joanne Wang <[email protected]> * fix gutter size Signed-off-by: Joanne Wang <[email protected]> * move edit under actions Signed-off-by: Joanne Wang <[email protected]> * fix notifications breadcrumb redirect Signed-off-by: Joanne Wang <[email protected]> * spacing from title to panel 16 for view monitor Signed-off-by: Joanne Wang <[email protected]> * fix some padding and remove horiz rule for findings section Signed-off-by: Joanne Wang <[email protected]> * change update monitor to edit monitor Signed-off-by: Joanne Wang <[email protected]> * change update to save and fix padding for create monitor Signed-off-by: Joanne Wang <[email protected]> * change monitor details padding and fix link to new page in alerts card Signed-off-by: Joanne Wang <[email protected]> * remove boarder when empty state Signed-off-by: Joanne Wang <[email protected]> * fix search bar spacing above Signed-off-by: Joanne Wang <[email protected]> * make create and edit monitor panels 16px padding Signed-off-by: Joanne Wang <[email protected]> * rename Signed-off-by: Joanne Wang <[email protected]> * fix original tabs Signed-off-by: Joanne Wang <[email protected]> * fix spacing on original monitor page Signed-off-by: Joanne Wang <[email protected]> * add pagination back to the alerts page Signed-off-by: Joanne Wang <[email protected]> * fix spacing for alerts dashboard flyout Signed-off-by: Joanne Wang <[email protected]> * cleanup Signed-off-by: Joanne Wang <[email protected]> * fix unit tests and run yarn test:jest -u Signed-off-by: Joanne Wang <[email protected]> * fix cypress tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 4a2b603) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
approved these changes
Sep 17, 2024
amsiglan
approved these changes
Sep 17, 2024
5 tasks
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
…-project#1094)" This reverts commit 51d2c95.
5 tasks
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
…-project#1094)" This reverts commit 51d2c95. Signed-off-by: AWSHurneyt <[email protected]>
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
…-project#1094)" This reverts commit 51d2c95.
5 tasks
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
…-project#1094)" This reverts commit 51d2c95. Signed-off-by: Joanne Wang <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "Fit and Finish UX changes Pt 2 (#1099) (#1107)" This reverts commit bfb0d79. Signed-off-by: Joanne Wang <[email protected]> * Revert "Fit and Finish UX Fixes (#1092) (#1094)" This reverts commit 51d2c95. Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4a2b603 from #1092.