Fit and Finish UX changes Pt 2 #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
jowg-amazon
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
amsiglan
reviewed
Sep 19, 2024
public/components/DataSourceAlertsCard/DataSourceAlertsCard.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Sep 19, 2024
public/components/DataSourceAlertsCard/DataSourceAlertsCard.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Joanne Wang <[email protected]>
|
Acknowledge alerts tests passed locally |
Signed-off-by: Joanne Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
- Coverage 48.41% 48.17% -0.25%
==========================================
Files 237 237
Lines 7052 7110 +58
Branches 1035 1045 +10
==========================================
+ Hits 3414 3425 +11
- Misses 3635 3682 +47
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joanne Wang <[email protected]>
amsiglan
approved these changes
Sep 20, 2024
AWSHurneyt
approved these changes
Sep 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* remove truncated monitor name Signed-off-by: Joanne Wang <[email protected]> * wip Signed-off-by: Joanne Wang <[email protected]> * fix alerts not showing up when no datasource id Signed-off-by: Joanne Wang <[email protected]> * fix url for composite monitors Signed-off-by: Joanne Wang <[email protected]> * check if datasource is enabled Signed-off-by: Joanne Wang <[email protected]> * fix overflow monitor name Signed-off-by: Joanne Wang <[email protected]> * make monitor name truncated dynamically Signed-off-by: Joanne Wang <[email protected]> * change mounting point id and fix sizing Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 42ee4fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* remove truncated monitor name Signed-off-by: Joanne Wang <[email protected]> * wip Signed-off-by: Joanne Wang <[email protected]> * fix alerts not showing up when no datasource id Signed-off-by: Joanne Wang <[email protected]> * fix url for composite monitors Signed-off-by: Joanne Wang <[email protected]> * check if datasource is enabled Signed-off-by: Joanne Wang <[email protected]> * fix overflow monitor name Signed-off-by: Joanne Wang <[email protected]> * make monitor name truncated dynamically Signed-off-by: Joanne Wang <[email protected]> * change mounting point id and fix sizing Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 42ee4fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Sep 20, 2024
* remove truncated monitor name * wip * fix alerts not showing up when no datasource id * fix url for composite monitors * check if datasource is enabled * fix overflow monitor name * make monitor name truncated dynamically * change mounting point id and fix sizing --------- (cherry picked from commit 42ee4fe) Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 20, 2024
* remove truncated monitor name Signed-off-by: Joanne Wang <[email protected]> * wip Signed-off-by: Joanne Wang <[email protected]> * fix alerts not showing up when no datasource id Signed-off-by: Joanne Wang <[email protected]> * fix url for composite monitors Signed-off-by: Joanne Wang <[email protected]> * check if datasource is enabled Signed-off-by: Joanne Wang <[email protected]> * fix overflow monitor name Signed-off-by: Joanne Wang <[email protected]> * make monitor name truncated dynamically Signed-off-by: Joanne Wang <[email protected]> * change mounting point id and fix sizing Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
5 tasks
riysaxen-amzn
pushed a commit
that referenced
this pull request
Sep 24, 2024
* remove truncated monitor name * wip * fix alerts not showing up when no datasource id * fix url for composite monitors * check if datasource is enabled * fix overflow monitor name * make monitor name truncated dynamically * change mounting point id and fix sizing --------- Signed-off-by: Joanne Wang <[email protected]>
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
…nsearch-project#1107)" This reverts commit bfb0d79. Signed-off-by: Joanne Wang <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "Fit and Finish UX changes Pt 2 (#1099) (#1107)" This reverts commit bfb0d79. Signed-off-by: Joanne Wang <[email protected]> * Revert "Fit and Finish UX Fixes (#1092) (#1094)" This reverts commit 51d2c95. Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second part of the fit and finish UX changes. This PR makes changes to the datasource alerts card which include:
Data source enabled
Data source disabled
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.