-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] AlertSummary still displays when agents required are not configured #1142
Open
000FLMS
wants to merge
8
commits into
opensearch-project:main
Choose a base branch
from
000FLMS:agent-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
000FLMS
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
October 25, 2024 10:59
000FLMS
changed the title
Fix alertSummary still displays when agents required are not configured
[Bug Fix] alertSummary still displays when agents required are not configured
Oct 25, 2024
000FLMS
changed the title
[Bug Fix] alertSummary still displays when agents required are not configured
[BugFix] alertSummary still displays when agents required are not configured
Oct 25, 2024
000FLMS
changed the title
[BugFix] alertSummary still displays when agents required are not configured
[BugFix] AlertSummary still displays when agents required are not configured
Oct 25, 2024
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: 000FLMS <[email protected]>
songkant-aws
reviewed
Nov 4, 2024
Signed-off-by: Sihan He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bug fix for alertSummary still displays when agents required are not configured in the selected datasource.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screenshots
data source with required agents configured
data source without agents