Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] AlertSummary still displays when agents required are not configured #1142

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

000FLMS
Copy link

@000FLMS 000FLMS commented Oct 25, 2024

Description

bug fix for alertSummary still displays when agents required are not configured in the selected datasource.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Screenshots

data source with required agents configured
image

data source without agents
image

@000FLMS 000FLMS changed the title Fix alertSummary still displays when agents required are not configured [Bug Fix] alertSummary still displays when agents required are not configured Oct 25, 2024
@000FLMS 000FLMS changed the title [Bug Fix] alertSummary still displays when agents required are not configured [BugFix] alertSummary still displays when agents required are not configured Oct 25, 2024
@000FLMS 000FLMS changed the title [BugFix] alertSummary still displays when agents required are not configured [BugFix] AlertSummary still displays when agents required are not configured Oct 25, 2024
public/pages/Dashboard/containers/Dashboard.js Outdated Show resolved Hide resolved
public/pages/Dashboard/containers/Dashboard.js Outdated Show resolved Hide resolved
public/pages/utils/helpers.js Outdated Show resolved Hide resolved
public/pages/Dashboard/containers/Dashboard.js Outdated Show resolved Hide resolved
public/plugin.tsx Outdated Show resolved Hide resolved
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants