Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update put route when flattening result index #1409

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

jackiehanyang
Copy link
Collaborator

@jackiehanyang jackiehanyang commented Feb 3, 2025

Description

update put route to enable flatten result index in put route

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jackie Han <[email protected]>
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (70eb089) to head (5f62c7f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../rest/handler/AbstractTimeSeriesActionHandler.java 80.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1409      +/-   ##
============================================
+ Coverage     81.53%   81.55%   +0.02%     
+ Complexity     5857     5856       -1     
============================================
  Files           533      533              
  Lines         23675    23664      -11     
  Branches       2375     2374       -1     
============================================
- Hits          19303    19300       -3     
+ Misses         3207     3199       -8     
  Partials       1165     1165              
Flag Coverage Δ
plugin 81.55% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/opensearch/timeseries/util/RestHandlerUtils.java 67.46% <ø> (+3.64%) ⬆️
.../rest/handler/AbstractTimeSeriesActionHandler.java 93.07% <80.00%> (-0.20%) ⬇️

... and 11 files with indirect coverage changes

@jackiehanyang jackiehanyang merged commit d4ce6cf into opensearch-project:main Feb 3, 2025
19 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2025
* update put route when flattening result index

Signed-off-by: Jackie Han <[email protected]>

* clean up unused code

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit d4ce6cf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2025
* update put route when flattening result index

Signed-off-by: Jackie Han <[email protected]>

* clean up unused code

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit d4ce6cf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang pushed a commit that referenced this pull request Feb 3, 2025
* update put route when flattening result index



* clean up unused code



---------


(cherry picked from commit d4ce6cf)

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang pushed a commit that referenced this pull request Feb 3, 2025
* update put route when flattening result index



* clean up unused code



---------


(cherry picked from commit d4ce6cf)

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jackiehanyang jackiehanyang mentioned this pull request Feb 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants