-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changelog verifier workflow #1413
Conversation
Signed-off-by: Owais <[email protected]>
3a88a43
to
c95f53e
Compare
So this will allow creating changelog every time merge a PR? |
Yes, devs need to add an entry into the CHANGELOG file every time they create a PR otherwise the CHANGELOG github action would fail. Next time while creating the release notes all the entries can be copied directly to the release notes and can be deleted from either 2.x or 3.0 section as a clean up. If for changes we don't need to add an entry for such PRs we can add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
============================================
- Coverage 81.56% 81.55% -0.02%
- Complexity 5856 5860 +4
============================================
Files 533 533
Lines 23664 23664
Branches 2374 2374
============================================
- Hits 19302 19299 -3
- Misses 3197 3204 +7
+ Partials 1165 1161 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Can you document the process in https://github.com/opensearch-project/anomaly-detection/blob/main/DEVELOPER_GUIDE.md ? |
6b52f9f
to
f581692
Compare
f581692
to
325268b
Compare
@kaituo BWC failure looks similar to opensearch-project/OpenSearch#15234. Is this safe to merge? |
Signed-off-by: Owais <[email protected]>
325268b
to
4e0877a
Compare
* Add Changelog verifier workflow Signed-off-by: Owais <[email protected]> * Add documentation Signed-off-by: Owais <[email protected]> --------- Signed-off-by: Owais <[email protected]> (cherry picked from commit f8307ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add Changelog verifier workflow * Add documentation --------- (cherry picked from commit f8307ab) Signed-off-by: Owais <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add Changelog verifier workflow for creating release notes faster
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.