Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .deb and .rpm Installation and make .tar Installation the Fallback #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jostrus
Copy link

@Jostrus Jostrus commented May 12, 2024

Description

These changes switch to an installation via .deb or .rpm depending on the underlying operating system and use the installation from the tar bundle as a fallback.
In addition, the installation and configuration have been split into two different YAML files and variables have been added for the RedHat and Debian operating systems

Issues Resolved

This PR will solve these two Issues:
#156
#56

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Member

Adding @peterzhuamazon to please take a look at the PR, also @Jostrus can you please fix the DCO check?

@peterzhuamazon
Copy link
Member

I think there was a discussion on switching to rpm but stopped.
In ODFE we used to use rpm tho I think.
cc @saravanan30erd into the conversation on this. Thanks.

Split Configuration and Installation into own .yml files
Add variables file for OS Specific Values

Signed-off-by: Johannes Wagner <[email protected]>
@Jostrus
Copy link
Author

Jostrus commented May 16, 2024

Hi @peterzhuamazon,
thanks for reviewing my PR.
I understand if the decision was made not to install OpenSearch via .rpm or .deb package.
If you prefer, I can rewrite my changes and make the tar install the default, and only if for example the os_repository variable is set to true it should be installed from the repository.
I still want to give the possibility to install from a package, because in this case OpenSearch is listed in the package manager database.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 16, 2024

Hi @peterzhuamazon, thanks for reviewing my PR. I understand if the decision was made not to install OpenSearch via .rpm or .deb package. If you prefer, I can rewrite my changes and make the tar install the default, and only if for example the os_repository variable is set to true it should be installed from the repository. I still want to give the possibility to install from a package, because in this case OpenSearch is listed in the package manager database.

Hi @Jostrus , It would be great to have different distribution options and I do agree with that.
My concern is whether this would make the playbook hard to maintain over time. In helm due to its relationship with k8s and docker containers, contributions will be focused only on one distribution, unlike ansible playbook you can add multiple.

Will wait for more comments from @saravanan30erd and @prudhvigodithi on this. Thanks.

@saravanan30erd
Copy link
Collaborator

My concern is whether this would make the playbook hard to maintain over time.

I completely agree with @peterzhuamazon on this point. Previously we had discussions about using .rpm, .deb packages for installation but opted out. Current installation is distro agnostic and pretty much supports most of the linux distributions. One example is, Initially we created and tested this playbook against RHEL7, Centos7 but it still works for recent releases like RHEL9 literally without any specific code changes. Adding multiple methods (specific to particular distros) for installation would make difficult to maintain over time.

@Jostrus
Copy link
Author

Jostrus commented May 19, 2024

Hey @peterzhuamazon and @saravanan30erd,
If that's better, I can rewrite my changes to only do the .deb and .rpm installs if the user explicitly selects that and default to the .tar install. I like distribution dependent installs for many reasons, so I will contribute to this repositroy as best I can.
If you still say no because it would be an unnecessary overhead, which I completely understand and sympathize with, I will respect that decision and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants