-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .deb and .rpm Installation and make .tar Installation the Fallback #158
base: main
Are you sure you want to change the base?
Conversation
Adding @peterzhuamazon to please take a look at the PR, also @Jostrus can you please fix the DCO check? |
I think there was a discussion on switching to rpm but stopped. |
Split Configuration and Installation into own .yml files Add variables file for OS Specific Values Signed-off-by: Johannes Wagner <[email protected]>
Hi @peterzhuamazon, |
Hi @Jostrus , It would be great to have different distribution options and I do agree with that. Will wait for more comments from @saravanan30erd and @prudhvigodithi on this. Thanks. |
I completely agree with @peterzhuamazon on this point. Previously we had discussions about using .rpm, .deb packages for installation but opted out. Current installation is distro agnostic and pretty much supports most of the linux distributions. One example is, Initially we created and tested this playbook against RHEL7, Centos7 but it still works for recent releases like RHEL9 literally without any specific code changes. Adding multiple methods (specific to particular distros) for installation would make difficult to maintain over time. |
Hey @peterzhuamazon and @saravanan30erd, |
Description
These changes switch to an installation via .deb or .rpm depending on the underlying operating system and use the installation from the tar bundle as a fallback.
In addition, the installation and configuration have been split into two different YAML files and variables have been added for the RedHat and Debian operating systems
Issues Resolved
This PR will solve these two Issues:
#156
#56
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.